CODEWITHSUNDEEP
unixprocessfilehandle
Magnus
Magnus

Reputation: 4714

Closing all open files in a process

How do I find all the open files in a process (from inside itself)?

This seems useful to know after a fork() (before exec()).

I know of the existance of getdtablesize() and the more portable sysconf(_SC_OPEN_MAX), but it seems inefficient to attempt closing every valid file descriptor, whether there's an open file behind it or not. (I am also aware of the dangers of premature optimisation, this is more about aesthetics I guess :-)

Upvotes: 19

Views: 24345

Answers (4)

AMADANON Inc.
AMADANON Inc.

Reputation: 5919

Having just spent many hours tracking down a bug, yes, closing all file descriptors can cause problems.

The question is, how many file descriptors are there?

1024 used to be very common, and 1024 is not an entirely unreasonable number of file handles to close. Since most of them are closed, this is just checking a byte in memory.

My operating system ships with a default of 1,048,576. On this (admittedly slow) server, it apparently can take over 4.7 microseconds to try to close a filehandle. This resulted in a timeout (5 seconds). And there's no telling how high the number will grow. At least put a (reasonable) upper limit on it.

/proc/self/fd is not ideal, but bugs like this are very hard to find.

Upvotes: 3

Edward Tomasz Napierala
Edward Tomasz Napierala

Reputation: 1846

On systems that support it (which basically means any unix other than Linux) there's the closefrom(2) system call, designed specifically for this purpose.

Upvotes: 5

R.. GitHub STOP HELPING ICE
R.. GitHub STOP HELPING ICE

Reputation: 215387

If your program will be calling fork and exec, you really should open all file descriptors with the O_CLOEXEC flag so you don't have to manually close them before exec. You can also use fcntl to add this flag after a file is opened, but that's subject to race conditions in multithreaded programs.

Upvotes: 9

Martin v. Löwis
Martin v. Löwis

Reputation: 127497

It may sound inefficient to attempt to close all file descriptors, but it actually is not that bad. The system call implementation to lookup a file descriptor should be fairly efficient if the system is any good.

If you want to find only close the open file descriptors, you can use the proc filesystem on systems where it exists. E.g. on Linux, /proc/self/fd will list all open file descriptors. Iterate over that directory, and close everything >2, excluding the file descriptor that denotes the directory you are iterating over.

Upvotes: 6

Related Questions