CODEWITHSUNDEEP
c++memory-leaks
Herb Slotinsky
Herb Slotinsky

Reputation: 129

Why is my destructor never called?

I have a base class A and a derived class B:

class A
{
public:
    virtual f();
};

class B : public A
{
public:
     B()
     {
         p = new char [100];
     }
     ~B()
     {
         delete [] p;
     }
     f();
private:
    char *p;
};

For any reason the destructor is never called - why? I dont understand this.

Upvotes: 11

Views: 6353

Answers (4)

Manfred Meyer
Manfred Meyer

Reputation: 365

Your base class needs a virtual destructor. Otherwise the destructor of the derived class will not be called, if only a pointer of type A* is used.

Add

virtual ~A() {};

to class A.

Upvotes: 35

jcoder
jcoder

Reputation: 30035

If your variable is of type A it doesn't have a virtual destructor and so it won't look at the actual runtime type of the object to determine it needs to call the desstructor

Add an empty destructor to A

virtual ~A() {}

and that should fix it.

In general you need to do this on any class that can possibly be used as a base class.

Upvotes: 3

shoosh
shoosh

Reputation: 78934

try this:

class A
{
public:
    virtual ~A() {}
    virtual f();
};

class B : public A
{
public:
     B()
     {
         p = new char [100];
     }
     virtual ~B() // virtual keywork optional but occasionally helpful for self documentation.
     {
         delete [] p;
     }
     f();
private:
    char *p;
};

Upvotes: 3

Andrew
Andrew

Reputation: 12009

Class A should have a virtual destructor. Without that, derive class destructors won't be called.

Upvotes: 7

Related Questions