CODEWITHSUNDEEP
phpjavascript
Roddeh
Roddeh

Reputation: 207

Can't find what's wrong in this code

I have the following script which brings up a dialog on my screen telling me there has been an error:

<script type="text/javascript">
var myFunc = function() 
{
    var html='<div class="cs-body">explanation of the error</div>';
    $(html).csDialog();
    return false;
};
</script>

I want this dialog to pop-up when my php script returns a "1" value for $error, like this:

if ($error==1) {
echo "<script type='javascript'>$(document).ready(myFunc)</script>";
}

Even if I leave the if-clause and just echo the script it doensn't do anything. Can somebody tell me what I'm missing here?

Thanks in advance!

Upvotes: 0

Views: 81

Answers (4)

Dinesh
Dinesh

Reputation: 3105

try this 

<?php if ($error==1) {  ?>
 <script type="text/javascript">
   $(document).ready(myFunc)
 </script>";

<?php } ?>

Dins

Upvotes: 0

Mihai
Mihai

Reputation: 2760

Check if you javascript function is defined when running this 

echo "<script type='javascript'>$(document).ready(myFunc)</script>

Include jQuery and your js function in the tag, just to see if it works. PS: you should only add js script in the tag if they are necessary right away, else, added them at the bottom of the tag. Remember, the loading of js files blocks the loading of any other page resources

Upvotes: 0

Roddeh
Roddeh

Reputation: 207

try changing script type from 'javascript' to 'text/javascript'

that did the trick! thanks lostsource!

Upvotes: 1

phant0m
phant0m

Reputation: 16905

You need to make sure, this script fragment is output after the inclusion of jQuery.

Upvotes: 0

Related Questions