CODEWITHSUNDEEP
c#wpfmvvmmessagebox
Jake Pearson
Jake Pearson

Reputation: 27757

MVVM Exception Handling

I have a WPF Application that I have been trying to write in the MVVM style. If an Exception is thrown (like when a document is opened), I would like to display a MessageBox. Easy to do, but my code doesn't feel quite right because the MessageBox.Show call is in the ModelView. I thought that sort of thing is supposed to live in the View, but I'm not supposed to put code in the View.

So the question really can be distilled down to what is the suggested way to display a MessageBox in MVVM?

Upvotes: 9

Views: 8453

Answers (3)

Kent Boogaart
Kent Boogaart

Reputation: 178810

Use a service:

public void SomeMethodInYourViewModel()
{
    try
    {
        DoSomethingDangerous();
    }
    catch (Exception ex)
    {
        ServiceLocator.Resolve<IMessageService>().ShowMessage(ex.Message);
    }
}

You have now decoupled your VMs from the presentation of messages. You may even decide not to use the standard (ugly) message boxes at all and that won't affect your VMs.

Upvotes: 17

Wayne Bloss
Wayne Bloss

Reputation: 5570

You might also like to just put an ErrorMessage string property on your ViewModel class that your View can bind to.

Upvotes: 2

kiwipom
kiwipom

Reputation: 7709

Have a look at Josh Smith's excellent MVVM Foundation on Codeplex. Specifically, have a look at the Messenger class, a lightweight way of passing messages between various ViewModel objects who do not need to be aware of each other.

Also, I don't believe there is a hard-and-fast rule on "No code in the View", although it's best to be avoided if possible... remember that your XAML is simply .net code written in a declarative syntax; the code-behind is just C# or VB.net to supplement that (if absolutely necessary!)

Upvotes: 9

Related Questions