CODEWITHSUNDEEP
ruby-on-railspostgresql
mhenrixon
mhenrixon

Reputation: 6278

Why does rake db:migrate sometimes add trailing whitespace to structure.sql?

On some of our developer machines rake db:migrate adds trailing whitespace to structure.sql which is really annoying because every time a change is made to the database we have to first remove all trailing whitespace from the file.

Anyone know what could be up with that? Where would the whitespace come from? Has it to do with PostgreSQL or is it something else?

Upvotes: 28

Views: 2452

Answers (6)

Ulysse BN
Ulysse BN

Reputation: 11386

It is the best day of my life, and maybe yours:

In PG 11, this error is not here anymore since Tablespace is not written to the dump. So you can upgrade your PG version and get rid of the hook you had for space deletion.

Upvotes: 0

A. Maly
A. Maly

Reputation: 315

This happens because of the version differences of your database on each machine.

You can either all have the same version, or in your text editor have it trim trailing spaces on save. In sublime add this line to your settings: "trim_trailing_white_space_on_save": true

Upvotes: 0

Charlie Tran
Charlie Tran

Reputation: 183

Here's a solution that you can commit to version control: trim the trailing whitespace as a db:migrate hook.

In lib/tasks/db.rake:

namespace :db do
  def remove_whitespace_in_structure
    if Rails.env.development?
      `sed -i '' -e's/[[:space:]]*$//' db/structure.sql`
    end
  end

  task :migrate do
    remove_whitespace_in_structure
  end
end

The above code may look like it's overwriting db:migrate, but it's a hook that will run right after the normal db:migrate task.

Upvotes: 11

jpbalarini
jpbalarini

Reputation: 1172

I am using this gem in one of my projects and it does the job.

https://github.com/jakeonrails/fix-db-schema-conflicts

When you run rake db:migrate it runs a couple of good things; one of them is the sed command that removes unnecessary whitespaces.

Upvotes: -2

Amiel Martin
Amiel Martin

Reputation: 4814

I just set up a git filter for this. Unfortunately, this is not something you can add to the repo; each team member will have to set it up.

In .gitconfig (or .git/config)

[filter "remove-trailing-whitespace"]
  clean = sed -E 's/[[:space:]]*$//'
  smudge = cat

In .gitattributes or .git/info/attributes

db/structure.sql filter=remove-trailing-whitespace

See the documentation on gitattributes for more information on git filters.

Upvotes: 7

Dimitrios Mistriotis
Dimitrios Mistriotis

Reputation: 2788

Having the same problem, I add the changes that have an actual effect through a git add -i db/structure.sql and then git checkout db/structure.sql so that the differences in spaces will be omitted.

The alternative we consider in our team is to use another gem for keeping track of the database.

Upvotes: 1

Related Questions