CODEWITHSUNDEEP
jquery
Shea Daniels
Shea Daniels

Reputation: 3270

Trouble with jQuery Animation

I'm fairly new to jQuery and I'm having trouble with an animation that I'd like to do.

Say I have some drops downs to filter content that use this HTML:

<table class="calFilter">
    <tr>
        <th>
            <label for="ddlDept">Show events hosted by:</label>
        </th>
        <th>
            <label for="ddlEventType">Select event type:</label>
        </th>
    </tr>
    <tr>
        <td>
            <select name="ddlDept" id="ddlDept" class="deptDropDown">
                <option value="">All</option>
                <option value="cfys">Community, Family, &amp; Youth Services</option>
                <option value="conser">Conservation Board</option>
                <option value="emergm">Emergency Management</option>
                <option value="health">Health Department</option>
            </select>
        </td>
        <td>
            <select name="ddlEventType" id="ddlEventType">
                <option value="0">All</option>
            </select>
        </td>
        <td>
            <input type="submit" name="cmdGo" value="Go" id="cmdGo" />
        </td>
    </tr>
</table>

If you select a different department, the event types no longer make sense, so I'd like to hide the Event Type label and drop down when the Dept drop down changes. I got this to work using the change event callback for the drop down and the simple hide() command.

But if I try to use animation, things go haywire. The controls don't slide the way I would expect, the animation occurs every time even if the controls are already hidden, etc.

I would like some sort of nice fade or slide, or some combination of those two. How would you do this?

Upvotes: 0

Views: 172

Answers (4)

Russ Cam
Russ Cam

Reputation: 125488

I think it's because you have the elements in a table layout that the animation is acting funny. To overcome this, you can hide the <td> elements that the elements you wish to hide are in as well.

Here's a Working Demo that is tested and works in Firefox 3.5 and IE6. Add /edit to the URL if you want to play around with it.

The code from the demo

$(function() {

    $('#ddlDept').change(function() {
      var label = $('label[for="ddlEventType"]');

      if (label.is(":visible")) {  
          label.parent().animate({ width: "0px" }).hide().end().hide();
          $('#ddlEventType').parent().animate({ width: "0px" }).hide().end().hide();
      }
    });

});

EDIT:

As discussed in the comments, here's a Working Demo that uses fadeTo() to first fade the elements before animating and hiding.

The code from the demo

$(function() {

    $('#ddlDept').change(function() {
      var label = $('label[for="ddlEventType"]');
      var select = $('#ddlEventType');

      if (label.is(":visible")) {  
          label.fadeTo("slow", 0.01, function() { 
                  label.parent()
                       .animate({ width: "0px"}, 500)
                       .hide()
                       .end()
                       .hide(); 
               });
          select.fadeTo("slow", 0.01, function() { 
                  select.parent()
                       .animate({ width: "0px"}, 500)
                       .hide()
                       .end()
                       .hide(); 
               });
      }
    });

});

Upvotes: 1

Andy Gaskell
Andy Gaskell

Reputation: 31761

Tables are pretty finicky when it comes to animation. fadeOut should work with tables, you'll have mixed results on different browsers with a lot of the other effects.

Upvotes: 1

idrumgood
idrumgood

Reputation: 4924

Try using slideDown() instead of hide() or see one of the many other built in show/hide animations at jquery.com

If it's still animating while it's already hidden, add something like this in your code:

if($('select#ddlEventType').not(':hidden')){
      $(this).slideDown();
}

Upvotes: 0

jeef3
jeef3

Reputation: 1997

You should first check if it is visible or not:

// Callback function
function() {
    var obj = $(this);
    if (obj.is(':visible')) { // make sure you're checking the visibility of one or both of the objects that are being hidden
        // hide
    } else {
        // show
    }
}

Upvotes: 0

Related Questions