CODEWITHSUNDEEP
c
good_evening
good_evening

Reputation: 21759

Valgrind gives me Invalid write of size 4 Address 0x4037268 is not stack'd, malloc'd or (recently) free'd

void merge(int left, int mid, int right)
{
  // sublist sizes
  int left_size = mid - left + 1;
  int right_size = right - mid;

  // counts
  int i, j, k;

  // create left and right arrays
  B left_list = malloc(left_size*sizeof(B));
  B right_list = malloc(right_size*sizeof(B));

  for (i = 0; i < left_size; i++)
    left_list[i] = list[left + i];

  for (j = 0; j < right_size; j++)
    right_list[j] = list[mid + j + 1];

  // reset counts
  i = 0; j = 0;

  for (k = left; k <= right; k++)
  {
    if (j == right_size)
      list[k] = left_list[i++];
    else if (i == left_size)
      list[k] = right_list[j++];
    // here we call the given comparision function
    else if (compar(&left_list[i], &right_list[j]) < 0)
      list[k] = left_list[i++];
    else
      list[k] = right_list[j++];
  }
}

void sort(int left, int right)
{
  if (left < right)
  {
    // find the pivot point
    int mid = (left + right) / 2;

    // recursive step
    sort(left, mid, compar);
    sort(mid + 1, right, compar);

    // merge resulting sublists
    merge(left, mid, right, compar);
  }
}

I just tried to test my program with valgrind, and got this below. 

==8679== Invalid write of size 4
==8679==    at 0x8048A30: merge (program.c:96)
==8679==    by 0x8048BF5: sort (program.c:116)
==8679==    by 0x8048C21: user_interface (program.c:124)
==8679==    by 0x8048E99: main (program.c:175)
==8679==  Address 0x4037268 is not stack'd, malloc'd or (recently) free'd

Upvotes: 0

Views: 403

Answers (1)

Sergey Kalinichenko
Sergey Kalinichenko

Reputation: 726929

Both your functions (sort and merge, that is) make an implicit assumption that the right end of the interval being sorted/merged is included in the range being sorted. This is unusual: a more typical approach is to include the left side of the interval, but exclude the right side. For example, the call of sort may look like this:

#define MAX 100
...
int list[MAX];
...
void sort(0, MAX, myComparator);

This will not work with your implementation: it expects a call that looks like this:

void sort(0, MAX-1 /* <<== Here */, myComparator);

Please check the way that you call sort; passing an inclusive right interval should fix the problem.

Upvotes: 1

Related Questions