CODEWITHSUNDEEP
android
powder366
powder366

Reputation: 4441

Custom EditTextPreference and setOnPreferenceChangeListener not called

My listener is not getting called for some reason? This is what I have:

In Preference file I have a custom EditTextPreference:

    <com.xxx.yyy.preference.PreferenceEditTextDialog
        android:layout="@layout/preference_edit"
        android:title="@string/title"
        android:summary="@string/summary"
        android:defaultValue=""
        android:dialogTitle="@string/dialogTitle"
        android:key="mypref"/>

I extend my class:

public class PreferenceEditTextDialog extends EditTextPreference {

Launching my Activity:

startActivity(new Intent(this, PrefsActivity.class));

Definition:

public class PrefsActivity extends PreferenceActivity implements   
OnPreferenceClickListener, OnSharedPreferenceChangeListener {

In here I register my setOnPreferenceChangeListener (which is not called).

However changing my Preference file from:

<com.xxx.yyy.preference.PreferenceEditTextDialog

to default:

<EditTextPreference

it all works. Could someone help me to find the problem, somehow the listener is not propagated properly using my custom Preference.

Thanks!

@Sam Here my listener definition:

    myfield = (EditTextPreference) getPreferenceScreen().findPreference(KEY_PREFERENCE);
    myfield.setOnPreferenceChangeListener(new OnPreferenceChangeListener() {

        @Override
        public boolean onPreferenceChange(Preference preference, Object newValue) {
            Boolean valid = true;
        if(!validate(newValue.toString())) {
               valid = false;
            }
            return valid;
        }
    });

Upvotes: 2

Views: 3832

Answers (1)

powder366
powder366

Reputation: 4441

Found a solution, in my custom EditTextPreference I added a call to callChangeListener(value):

@Override
public void onBindDialogView(View view) {       
edittext = (EditText) view.findViewById(R.id.edittext);
edittext.setText(PreferenceManager.
        getDefaultSharedPreferences(view.getContext()).
        getString(getKey(), ""));       

ok_button = (Button) view.findViewById(R.id.ok_button);
ok_button.setOnClickListener(new OnClickListener() {
    @Override
    public void onClick(View v) {
        String value = edittext.getText().toString();
        if(callChangeListener(value)) {
            Editor editor = getEditor();
            editor.putString(getKey(), value);
            editor.commit();
            getDialog().dismiss();
        }
    }
});

Upvotes: 5

Related Questions