CODEWITHSUNDEEP
jquery
Zian Choy
Zian Choy

Reputation: 2894

Why does jQuery's .each function repeat itself?

The goal of the following bit of code is to toggle a group of radio buttons named "knowsnumberofpeople". Unfortunately, after the first message box shows up and the radio buttons change correctly, jQuery goes back and toggles everything to the original state.

Why does jQuery go back on previous items in the collection?

Code:

 <script type="text/javascript">
        $("input[name='numberofpeople']").change(function() {
            $("input[name='knowsnumberofpeople']").each(function() {
            alert("Hi there.");                
                if ($(this).attr("checked") === "Checked") {
                    $(this).attr("checked", "");
                }
                else {
                    $(this).attr("checked", "Checked");
                }
            }
            );
        }
        );
    </script>

Edit

To answer questions and comments...

No, the two things are different. One radio button has a textbox and the other one doesn't. Both radio buttons all have the same name. The radio buttons are named knowsnumberofpoeple and the textbox is named numberofpeople. They radio buttons have the same ID, thanks to ASP .NET MVC (I tried setting their id through htmlAttribute, didn't work out).

They go to their original state.

There are no events bound to the knowsnumberofpeople control.

Why not read the value and set it?

I tried and it doesn't work:

$("input[name='knowsnumberofpeople']").val = true;

karbassi's solution doesn't work either. It just toggles the second radio button (the one without a textbox).

More Code

<form action="/ReserveSpace/ExpectedAttendance" method="post">
    <fieldset class="smallform">
        <input id="knowsnumberofpeople" name="knowsnumberofpeople" type="radio" value="True" />
        <input id="numberofpeople" name="numberofpeople" type="text" value="" />

        <label for="numberofpeople">
            (e.g. 20)</label><br />
        <input checked="checked" id="knowsnumberofpeople" name="knowsnumberofpeople" type="radio" value="False" />
        <label>
            I'm not sure.
        </label>
        <p>
            <input type="submit" value="Next" accesskey="N" /></p>
    </fieldset>
    </form>

Upvotes: 0

Views: 1451

Answers (3)

Zian Choy
Zian Choy

Reputation: 2894

Solution, found thanks to http://www.electrictoolbox.com/jquery-get-set-form-values/

        $("input[name='numberofpeople']").change(updateRadioButtons);

    function updateRadioButtons() {
        if ($("input[name='numberofpeople']").val() == "") {
            $("input[name=knowsnumberofpeople]")[1].checked = true;
        }
        else {
            $("input[name=knowsnumberofpeople]")[0].checked = true;
        }
    }

Thanks for everyone's help and I've up-voted answers that were particularly helpful.

Upvotes: 0

Powerlord
Powerlord

Reputation: 88816

If you're checking to see if a checkbox/radio button is checked, use

$(this).is(":checked")

Second, your code has a major logic bug. Only one radio button can be checked at any given time, but your code goes through and "checks" every radio button that isn't already checked.

So, no matter what you do, the last option should be checked, unless it's already checked, in which case none of the options would be checked.

Shouldn't you just be reading a value from numberofpeople, then select the appropriate radio button that way?

Upvotes: 2

Ali Karbassi
Ali Karbassi

Reputation: 685

Try this:

<script type="text/javascript">
   $("input[name='numberofpeople']").change(function() {
      $("input[name='knowsnumberofpeople']").each(function() {
         if ($(this + ":checked").length > 0) {
            $(this).attr("checked", "");
         } else {
            $(this).attr("checked", "Checked");
         }
      });
   });
</script>

Basically, you are using the $('input:checked') selector in jQuery.

ON SECOND THOUGHT, USE THIS

<script type="text/javascript">
   var tog = false; // or true if they are checked on load 

   $("input[name='numberofpeople']").change(function() {
      $("input[name=knowsnumberofpeople]").attr("checked", !tog);
      tog = !tog; 
   });
</script>

Upvotes: 1

Related Questions