CODEWITHSUNDEEP
ios
agierens
agierens

Reputation: 132

What is wrong with this animation for bring up a pickerview?

All code before the animation:

int height = 255;

//create new view
self.NewView = [[UIView alloc] initWithFrame:CGRectMake(0, 200, 320, height)];
self.NewView.backgroundColor = [UIColor colorWithWhite:1 alpha:1];

//add toolbar
UIToolbar * toolbar = [[UIToolbar alloc] initWithFrame: CGRectMake(0, 0, 320, 45)];
toolbar.barStyle = UIBarStyleBlack;

//add buttons
UIBarButtonItem *infoButtonItem = [[UIBarButtonItem alloc] initWithTitle:@"Done" style:UIBarButtonItemStyleDone target:nil action:@selector(dismissCustom:)];

UIBarButtonItem *flexible = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil action:nil];

UIBarButtonItem *cancelButton = [[UIBarButtonItem alloc] initWithTitle:@"Cancel" style:UIBarButtonItemStyleBordered target:nil action:@selector(cancelView:)];

toolbar.items = [NSArray arrayWithObjects:cancelButton, flexible, infoButtonItem, nil];
//add date picker
self.datePicker = [[UIDatePicker alloc] init];
self.datePicker.datePickerMode = UIDatePickerModeDateAndTime ;
self.datePicker.hidden = NO;
self.datePicker.date = [NSDate date];
self.datePicker.frame = CGRectMake(0, 40, 320, 250);
[self.datePicker addTarget:self action:nil forControlEvents:UIControlEventValueChanged];
[self.NewView addSubview:self.datePicker];

[self.NewView addSubview:toolbar];

ANIMATION CODE to make the view visible:

 __block CGRect temp = self.NewView.frame;
    temp.origin.y = CGRectGetMaxY(self.view.bounds);
    [UIView animateWithDuration:0.5 animations:^{temp.origin.y -= height, self.NewView.frame = temp;} completion:^(BOOL finished) {
        [self.view addSubview:self.NewView];}];

I have the pretty much the same code to get rid of it and it works fine!

int height = 0;
__block CGRect temp = self.NewView.frame;
temp.origin.y = CGRectGetMaxY(self.view.bounds);
[UIView animateWithDuration:0.5 animations:^{temp.origin.y -= height, self.NewView.frame = temp;} completion:^(BOOL finished) {
    [self.NewView removeFromSuperview];}];

Anyone have an idea of what is wrong? The view just appears where it is meant to slide too.

Upvotes: 0

Views: 77

Answers (1)

kutschenator
kutschenator

Reputation: 922

The problem is that you only add NewView as a subview AFTER the animation is completed. You have to add it before, like this:

__block CGRect temp = self.NewView.frame;
temp.origin.y = CGRectGetMaxY(self.view.bounds);
[self.view addSubview:self.NewView];
[UIView animateWithDuration:0.5 animations:^{temp.origin.y -= height, self.NewView.frame = temp;} completion:nil];

Upvotes: 1

Related Questions