CODEWITHSUNDEEP
cmemory-managementmemory-leaksfreevalgrind
Charlie Epps
Charlie Epps

Reputation: 3675

free() errors (debugging with valgrind)?

I have these structs:

typedef struct _Frag{
  struct _Frag *next;
  char *seq;
  int x1; 
  int length;  
}Frag;

typedef struct _Fragment{ 
  int type; 
  Frag *frag_list;   
}Fragment;

And then I created a array

Fragment *fragments=malloc(1,sizeof(Fragment)); // or more
fragments->frag_list=malloc(1,sizeof(Frag)); // or more
Frag *frag=malloc(10,sizeof(Frag));
frag->seq="test str\n";
...
frag->next=malloc(1,sizeof(Frag));
frag->next->seq="test str\n";

At the end of program, I want to free the memory, the function is:

static void free_frags(){
  int i;
  Fragment *fragment;
  Frag *current,*next;
  for(i=0;i<1;i++){
    fragment=&snp_frags[i];
    current=fragment->frag_list;
    next=current->next;

    while(next!=NULL){
      free(current->seq);
      //free(current->next);
      free(current);
      current=next;
      next=current->next;
    }
    free(current->seq);
    //free(current->next);
    free(current);
    //free(fragment->frag_list);
    free(&snp_frags[i]);
  }
  free(snp_frags);
}

If I use valgrind to debug it, valgrind says that:

=============================================
==3810== Invalid read of size 4
==3810==    at 0x80490FD: free_snp (hap.c:16)
==3810==    by 0x80493AF: main (hap.c:73)
==3810==  Address 0x41b139c is 12 bytes inside a block of size 296 free'd
==3810==    at 0x4023EBA: free (in /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so)
==3810==    by 0x8049167: free_snp (hap.c:30)
==3810==    by 0x80493AF: main (hap.c:73)
==3810== 
==3810== Invalid free() / delete / delete[]
==3810==    at 0x4023EBA: free (in /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so)
==3810==    by 0x8049167: free_snp (hap.c:30)
==3810==    by 0x80493AF: main (hap.c:73)
==3810==  Address 0x41b1398 is 8 bytes inside a block of size 296 free'd
==3810==    at 0x4023EBA: free (in /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so)
==3810==    by 0x8049167: free_snp (hap.c:30)
==3810==    by 0x80493AF: main (hap.c:73)

And please help me to fix these errors, thanx.

Upvotes: 0

Views: 1399

Answers (4)

DigitalRoss
DigitalRoss

Reputation: 146063

You seemed to be saying that you are freeing this memory as the last thing the program does.

Why bother? Why not just exit? Then your deallocation will be perfect, and faster. It is in fact the recommended technique.

I'm pretty sure no commenter will be able to cite an example of an OS that does not free memory resources from programs that terminate. Without this critical OS feature, ^C, kill, task manager, program bugs, program crashes ... every abnormal termination would leak memory.

Upvotes: 1

Charlie Epps
Charlie Epps

Reputation: 3675

remove the code line "free(fragment)". It will work well.

Upvotes: 0

sharptooth
sharptooth

Reputation: 170499

In

frag->seq="test str\n";

you haven't malloc'ed the memory block - the string is allocated in static storage - and later you try to free() that memory block. You can only free() blocks allocated with malloc(), otherwise you risk running into undefined behaviour.

You could either only put pointers to statically allocated strings into Frag::seq fields and never free() them or you could malloc() memory for these strings and copy the strings into malloc'ed blocks.

Upvotes: 7

Chris Lutz
Chris Lutz

Reputation: 75399

  1. You're frequently calling molloc() instead of malloc(). Check your vowels.
  2. You're calling malloc() with the wrong number of arguments - it only takes one.
  3. You can't assign strings - that performs pointer assignment, which is not what you want. You have to use strcpy() or strncpy() or memcpy(), depending on your religious perspective on the whole *cpy() mess, to copy the contents of one string into another.

Upvotes: 1

Related Questions