CODEWITHSUNDEEP
javascriptjquerycsswrapperunwrap
Sébastien Gicquel
Sébastien Gicquel

Reputation: 4386

How to remove span inside an element?

The following code adds and removes an "active" class to a menu (.active) It also adds a span class to the active link <span class="filet_menu"></span>.

How can I remove this span class? I've tried unwrap but it doesn't remove the span class "unwrap".

Here is my code:

$("#menu a").click(function() {
  $("#menu a").each(function() {
    $(this).removeClass("active");

    //Don't work :
    //$(this).unwrap('<span class="filet_menu"></span>');
    //$(this).contents().unwrap();
    //$('(this) > .active').unwrap();
  });
  $(this).addClass("active");
  $(this).wrapInner('<span class="filet_menu"></span>');
});
.active {
  color: #32c0ce !important;
}

.filet_menu {
  border-bottom: 2px solid #32c0ce;
  padding-bottom: 2px;
}
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<body>
  <div id="header">
    <div id="contenu_header">
      <h1>Sébastien Gicquel</h1>
      <ul id="menu">
        <li><a id="bt_diaporama" href="#diaporama">Home</a></li>
        <li><a id="bt_presentation" href="#presentation">Présentation</a></li>
        <li><a id="bt_realisations" href="#realisations">Réalisations</a></li>
        <li><a id="bt_contact" href="#contact">Contact</a></li>
      </ul>
    </div>
    <!-- fin contenu_header -->
  </div>
  <!-- fin header -->
  <div id="page">

Upvotes: 3

Views: 6154

Answers (4)

wirey00
wirey00

Reputation: 33661

You need to get to the contents first to unwrap. And you don't need the each loop

$("#menu a").click(function() {         
     $("#menu a.active").removeClass("active");
     $(this).addClass("active");
     $('span.filet_menu').contents().unwrap();// get previous span contents first and unwrap
     $(this).wrapInner('<span class="filet_menu"></span>');// this wraps current anchor's contents  
 });

http://jsfiddle.net/syXnH/

Or do you really need the span? why not just add/remove the classes

$("#menu a").click(function() {
    $("#menu a.active").removeClass("active filet_menu");
    $(this).addClass('filet_menu active');
});​

http://jsfiddle.net/HwTNz/

Upvotes: 3

Explosion Pills
Explosion Pills

Reputation: 191789

$(".filet_menu", this).each(function () {
   $(this).replaceWith(this.childNodes);
});

http://jsfiddle.net/LMm28/

On the other hand it may be easier to just have the span there the whole time and just add/remove the .filet_menu class.

Upvotes: 1

roryf
roryf

Reputation: 30170

Couple of suggestions for improving your code:

  • Rather than adding and removing the <span>, create it once for each item at load time. Each time you modify the DOM the browser has to perform expensive layout calculations. You can the control it's display via CSS, depending on it's parent active class.
  • You don't need to iterate every menu item to remove the active class, just use a selector

JavaScript:

$("#menu a").each(function() {
    $(this).wrapInner('<span class="filet_menu"></span>');
    $(this).click(function() {
        $('#menu a.active').removeClass('active');
        $(this).addClass('active');
    });
});

CSS:

.active
{
    color:#32c0ce !important;
}

.active .filet_menu
{
    border-bottom: 2px solid #32c0ce;
    padding-bottom:2px;
}

Upvotes: 1

user59169
user59169

Reputation: 138

I believe you want to remove the span, but preserve the data inside the span, so the .remove() won't work for you. You can just use this:

$(this).html(
    $(this).find("span.filet_menu").html()
);

Upvotes: 2

Related Questions