Kendo-Knockout: Window does not close correctly

Question

I am using RPNiemeyer kendo-knockout library. I have a grid. When the user clicks on a row of grid a pop up window is showed. When You close the window and open it again in the same way the application freezes with the closing animation. I tried as much as I can to reproduce this scenario in fiddle. In fiddle when You close the pop up window and click on the row again nothing happens and the browser is reloaded. I strongly believe that something similar is happening in my application.

html:

javascript:

$(function () {

    var elementIsBoundNew = function (element) {
        return !!ko.dataFor(element);
    }

    var applyBindings = function (viewModel, elementId) {
        var element = $('div[data-viewId="' + elementId + '"]')[0];
        if (!elementIsBoundNew(element)) {
            var parentViewModel = { viewModel: viewModel };
            ko.applyBindings(parentViewModel, element);
        }
    };

    var FranchiseDetailsViewModel = function () {
        var 
            self = this,
            initialize = function () {
                self.languagesInfoViewModel(new LanguageListViewModel(self));
                applyBindings(self.languagesInfoViewModel, "languageList");
            };

        FranchiseDetailsViewModel.prototype.languagesInfoViewModel = ko.observable();
        initialize();
    };

    var LanguageListViewModel = function (franchise) {
        var 
            self = this,
            initialize = function () {
                var languageViewModel = new LanguageDetailsViewModel(franchise);
                self.languageViewModels.push(languageViewModel);
            };
        LanguageListViewModel.prototype.languageViewModels = ko.observableArray([]);
        LanguageListViewModel.prototype.selectedLanguageViewModel = ko.observable();

        LanguageListViewModel.prototype.onLanguageSelected = function (selectedLanguage) {
  // when you uncomment this line everyting works fine
  //var language = new LanguageDetailsViewModel();  
            self.selectedLanguageViewModel(self.languageViewModels()[0]);

            applyBindings(self.selectedLanguageViewModel, "languageDetails");

            self.selectedLanguageViewModel().openPopUp();
        };
        initialize();
    };

    var LanguageDetailsViewModel = function () {
        var 
            self = this,
            closePopUp = function () {
                self.isOpen(false);
            };

        self.Language = ko.observable("English");

        LanguageDetailsViewModel.prototype.isOpen = ko.observable(false);

        LanguageDetailsViewModel.prototype.openPopUp = function () {
            self.isOpen(true);
        };

        LanguageDetailsViewModel.prototype.cancelLanguage = function () {
            closePopUp();
        };

    };

    var initialize = new FranchiseDetailsViewModel();
});

The strange thing is that if I add this line of code to my onLanguageSelected method everyting works fine:

var language = new LanguageDetailsViewModel();

Fiddle:

http://jsfiddle.net/bZF9k/26/

Any help with working example will be greatly appreciated. Thanks!

Update per RPNiemeyer`s post:

I have added these lines of code to use the technique from here Kendo-Knockout: Calling a method that changes viewmodel property from a template with data-binding inside a grid, breaks bindings:

 ko.bindingHandlers.preventBinding = {
      init: function() {
          return { controlsDescendantBindings: true };
      }        
    };

    ko.bindingHandlers.kendoGrid.options.dataBound = function(data) {
      var body = this.element.find("tbody")[0];

      if (body) {
         ko.applyBindings(ko.dataFor(body), body);   
      }
    };

This is exactly what is happening in my application. When I open the pop up, close it and than open it again for the second time it is not closing correctly. Please see my updated fiddle:

http://jsfiddle.net/bZF9k/29/

What am I missing ? Thank You once again for your feedback!

RP Niemeyer · Accepted Answer

It looks like the window is not properly cleaned up after it is closed. This is normally not a problem (and is desirable), but if the grid is re-rendered, then a new kendoWindow is initialized that does not know that there is a window already out there.

It might be possible to handle this in the knockout-kendo code. The destroy method of the window is already called, so I would need to look into why it is not actually removing the window elements.

A workaround for now is to configure a global handler for when a window is closed like:

  ko.bindingHandlers.kendoWindow.options.close = function() {
      $('.k-window, .k-overlay').remove();
  };

Sample here: http://jsfiddle.net/rniemeyer/dcYRM/

Kendo-Knockout: Window does not close correctly

Answers (2)

Related Questions