CODEWITHSUNDEEP
phpupload
Daelan
Daelan

Reputation: 723

PHP Multi file upload only first image uploading

I'm uploading images using multiple instances of the following file input:

<input type="file" name="photos[]">

I've set the form properties like this:

<form action="?action=form" method="post" class="nice" enctype="multipart/form-data">

When I loop through the files array I can print out the multiple file names.

But as soon as I try to upload the files it only uploads the first file from the array.

Here is my PHP:

$uploadDir = '/uploads/';

$getCurrentTimeStamp = date('m-d-Y_h.i.s', time());

// Set the allowed file extensions
$fileTypes = array('jpg', 'jpeg', 'png', 'gif'); // Allowed file extensions

$theIds = $_POST["id"];

function findexts ($filename) 
 { 
 $filename = strtolower($filename) ; 
 $exts = split("[/\\.]", $filename) ; 
 $n = count($exts)-1; 
 $exts = $exts[$n]; 
 return $exts; 
 } 

 //This applies the function to our file  

 $fileCount = 1;
foreach ($_FILES["photos"]["error"] as $key => $error) {
    if ($error == UPLOAD_ERR_OK) {


 $ext = findexts ($_FILES['photos']['name'][$key]) ; 

if (!empty($_FILES)) {
    $tempFile   = $_FILES['photos']['tmp_name'][$key];
    $uploadDir  = $_SERVER['DOCUMENT_ROOT'] . $uploadDir;

    $targetFile = $uploadDir . "equipment_photo_" .$theIds . "_".$fileCount."_". $getCurrentTimeStamp."." .$ext;
    $theFileNameToStore = "equipment_photo_" .$theIds . "_".$fileCount."_". $getCurrentTimeStamp."." .$ext;

    // Validate the filetype
    $fileParts = pathinfo($_FILES['photos']['name'][$key]);



    if (in_array(strtolower($fileParts['extension']), $fileTypes)) {

        // Save the file
        move_uploaded_file($tempFile,$targetFile);

        echo $theFileNameToStore;

    } else {

        // The file type wasn't allowed
        echo 'Invalid file type.';

    }
}


        }


        $fileCount ++;

}

Any ideas why the multiple images will echo but the files won't upload?

Upvotes: 1

Views: 1396

Answers (1)

pocesar
pocesar

Reputation: 7050

To make your life easier, I'd suggest you to use this function to reorder the $_FILES global

function rotate_array($source_array, $keep_keys = TRUE)
{
  $new_array = array();

  foreach ($source_array as $key => $value)
  {
     $value = ($keep_keys === TRUE) ? $value : array_values($value);
     foreach ($value as $k => $v)
     {
        $new_array[$k][$key] = $v;
     }
  }

  return $new_array;
}

Then use it in your code:

$fileCount = 1;
$files = rotate_array($_FILES['photos']);

foreach ($files as $file) {
  if (is_uploaded_file($file['tmp_name'])) {
    $ext = findexts($file['name']); 

    $tempFile   = $file['tmp_name'];
    $uploadDir  = $_SERVER['DOCUMENT_ROOT'] . $uploadDir;

    $theFileNameToStore = "equipment_photo_" .$theIds . "_".$fileCount."_". $getCurrentTimeStamp."." .$ext;
    $targetFile = $uploadDir . $theFileNameToStore;

    // Validate the filetype
    $fileParts = pathinfo($file['name']);

    if (in_array(strtolower($fileParts['extension']), $fileTypes)) {
      // Save the file
      //move_uploaded_file($tempFile,$targetFile);
      // Sometimes move won't work for unknown reasons, try copying, this should work
      copy($tempFile, $targetFile);

      echo $theFileNameToStore;
    } else {
      // The file type wasn't allowed 
      echo 'Invalid file type.';
    }
  }
  $fileCount ++;
}

make sure your phpinfo() shows the correct value for max_file_uploads, upload_max_filesize and post_max_size. Change either on your code, or inside your php.ini file

Upvotes: 1

Related Questions