CODEWITHSUNDEEP
javajava.util.scanner
JavaNewbie_M107
JavaNewbie_M107

Reputation: 2037

Close a Scanner linked to System.in

I have a Scanner linked to System.in. Now, after using the Scanner, I should close it, as it is bad coding practice to leave it open. But, if I close the Scanner, I will also be closing System.in! Can anyone tell me how I can close the Scanner without closing System.in (if there is any way).

Upvotes: 48

Views: 22992

Answers (5)

H.v.M.
H.v.M.

Reputation: 1659

I have vague memories of strange, undiagnosable problems long ago with using the same Scanner of System.in twice, so this is what I use (even though you should probably just use one scanner for the duration of the program):

static String input() {
    try {
        return new Scanner(System.in).nextLine();
    } catch (NoSuchElementException e) {
        throw e;
    }
}

For some reason this works without warnings, whereas if I don't do the catch-throw, Eclipse will complain Resource leak: '<unassigned Closeable value>' is never closed.

Upvotes: -1

Ted McLeod
Ted McLeod

Reputation: 5

According to the API for InputSteam "The close method of InputStream does nothing.", so since System.in is an instance of InputStream, you don't need to worry about close() being called on it.

Upvotes: -12

paul jerman
paul jerman

Reputation: 611

One option is to wrap your System.in stream in a CloseShieldInputStream that prevents it from being closed. Your reader would then use the CloseShieldInputStream rather than the raw System.in stream.

Here is the API for the class: http://commons.apache.org/io/apidocs/org/apache/commons/io/input/CloseShieldInputStream.html

Upvotes: 28

mist
mist

Reputation: 1853

Instead of adding shield classes and stuff like that, just put a nice comment and a 

        @SuppressWarnings("resource")

That's good enough. And I don't seem to see a lot of drawbacks to this approach. Don't forget the comment.

Upvotes: 10

Peter Lawrey
Peter Lawrey

Reputation: 533670

The simplest thing is to not close Scanner if you don't want to close the underlying stream.

Ideally you should create just one Scanner which you use for the life of the program. In any case, it appears you don't have a good reason to close it.

Upvotes: 33

Related Questions