CODEWITHSUNDEEP
javascriptember.jsember-data
Riad
Riad

Reputation: 235

How to make embedded hasMany relationships work with ember data

I can't get embedded hasMany to work correctly with ember data.

I have something like this

App.Post = DS.Model.extend({
  comments: DS.hasMany('App.Comment')
});

App.Comment = DS.Model.extend({
  post: DS.hasMany('App.Post'),
  name: attr('string')
});

And my API returns the following for GET /post:

[
  {
   id: 1
   comments: [{name: 'test'}, {name: 'test2'}]
  },
  ...
]

I need to send this with POST /post:

[
  {
    comments: [{name: 'test'}, {name: 'test2'}]
  },
  ...
]

I want to work with Ember models and have them make the appropriate requests:

var post = App.store.createRecord(App.Post, hash_post_without_comments);
post.get('comments').createRecord(hash_comment);

App.store.commit(); // This should call the POST api

and

var posts = App.store.find(App.Post); // This should call the GET api

When I try something like post: DS.hasMany('App.Post', {embedded: true}), the GET is working but the POST is trying to make a POST for the two records not only the parent one.

EDIT : My Real use case

1- I've just built ember data from master

2- My adapter: RESTAdapter

3- The serializer: JSONSerializer

4- I added

App.MyAdapter.map('App.Join', {
    columns: { embedded: 'always' }
});

5- My Models are:

App.Join = DS.Model.extend({
    rowCount: DS.attr('number'),
    columns: DS.hasMany('App.JoinColumn'),
});

App.JoinColumn = DS.Model.extend({
    join: DS.belongsTo('App.Join')
});

6- When:

var a = App.Join.find(1);
a.get('columns').createRecord({});
App.store.commit();

a POST for joincolumn is sent and the parent is not dirty

What am i missing?

Upvotes: 17

Views: 15359

Answers (4)

Patrick Fisher
Patrick Fisher

Reputation: 8055

This is what worked for me (Ember 1.5.1+pre.5349ffcb, Ember Data 1.0.0-beta.7.f87cba88):

App.Post = DS.Model.extend({
  comments: DS.hasMany('comment', { embedded: 'always' })
});

App.PostSerializer = DS.ActiveModelSerializer.extend(DS.EmbeddedRecordsMixin, {
  attrs: {
    comments: { embedded: 'always' }
  }
});

Upvotes: 5

steakchaser
steakchaser

Reputation: 5239

Adding an update to this incase others come across this post and are having a hard time figuring out what works with the current version of ember-data.

As of Ember Data 1.0.0.beta.7, you need to override the appropriate methods on the serializer. Here's an example:

1) Reopen the serializer (credit to this post):

DS.RESTSerializer.reopen({
  serializeHasMany: function(record, json, relationship) {
    var hasManyRecords, key;
    key = relationship.key;
    hasManyRecords = Ember.get(record, key);
    if (hasManyRecords && relationship.options.embedded === "always") {
      json[key] = [];
      hasManyRecords.forEach(function(item, index) {
        // use includeId: true if you want the id of each model on the hasMany relationship
        json[key].push(item.serialize({ includeId: true }));
      });
    } else {
      this._super(record, json, relationship);
    }
  }
});

2) Add the embedded: 'always' option to the relationship on the model:

App.Post = DS.Model.extend({
  comments: DS.hasMany('comment', {
    embedded: 'always'
  })
});

Upvotes: 5

Yehuda Katz
Yehuda Katz

Reputation: 28703

On master, the correct API is:

App.Adapter.map('App.Post', {
  comments: { embedded: 'always' }
});

The two possible values of embedded are:

  • load: The child records are embedded when loading, but should be saved as standalone records. In order for this to work, the child records must have an ID.
  • always: The child records are embedded when loading, and are saved embedded in the same record. This, of course, affects the dirtiness of the records (if the child record changes, the adapter will mark the parent record as dirty).

If you don't have a custom adapter, you can call map directly on DS.RESTAdapter:

DS.RESTAdapter.map('App.Post', {
  comments: { embedded: 'always' }
});

Upvotes: 46

bobey
bobey

Reputation: 98

I have the exact same problem.

This bug has been reported on the ember data issue tracker. The following PR adds 2 failing tests showing the problem: https://github.com/emberjs/data/pull/578

It seems that there is no workaround right now.

EDIT:

sebastianseilund opened a PR 2 days ago which fixes your problem. Have a look at: https://github.com/emberjs/data/pull/629/files

Upvotes: 7

Related Questions