CODEWITHSUNDEEP
ruby-on-railsrubyattributesvirtual
holden
holden

Reputation: 13581

virtual attribute problems with undefined methods

I've used Virtual attributes in the past but I can't seem to get past this, and I know the answer is probably staring me in the face.

I have a model like so:

model Confirmation.rb

class Confirmation < ActiveRecord::Base

  #attr_accessible :confirmation, :confirmation_token
  #attr_accessible :confirmation_token

  def confirmation_token
    confirmation.confirmation_token if confirmation
  end

  def confirmation_token=(token)
    self.confirmation = Booking.find_by_confirmation_token(token)
  end

end

Your average scaffold controller for

confirmations_controller.rb

  def new
    @confirmation = Confirmation.new(:confirmation_token => params[:confirmation_token])

    respond_to do |format|
      format.html # new.html.erb
      format.xml  { render :xml => @confirmation }
    end
  end

new.html.erb

<h1>New confirmation</h1>

<% form_for(@confirmation) do |f| %>
  <%= f.error_messages %>

    <%= f.hidden_field :confirmation_token %>

...

routes.rb

  map.confirmation "confirmation/:confirmation_token", :controller => "confirmations", :action => "new"
  map.resources :confirmations

error

undefined method `confirmation=' for #

In the console Booking.find_by_confirmation_token(token) with a given token works perfectly fine.

Any ideas? suggestions?

Upvotes: 0

Views: 2533

Answers (3)

Andrius
Andrius

Reputation: 2818

What you really need is attr_accessor :confirmation. There's a difference between attr_accessible and attr_accessor.

attr_accessor :confirmation

is same as

def confirmation
  @confirmation
end

def confirmation=(value)
  @confirmation = value
end

Now since it's such a common pattern ruby introduced helper methods for that.

Attr_accesible on the other hand is rails method, which marks that certain fields can be mass updated.

Upvotes: 5

holden
holden

Reputation: 13581

class Confirmation < ActiveRecord::Base
  belongs_to :bookings

  #attr_accessible :confirmation, :confirmation_token
  #attr_accessible :confirmation

  def confirmation_token
    @confirmation.confirmation_token if @confirmation
  end

  def confirmation_token=(token)
    @confirmation = Booking.find_by_confirmation_token(token)
  end

end

this worked... however just uncovering the attr_accessible :confirmation, did not. self.confirmation still returned undefined method...

Upvotes: 0

Koraktor
Koraktor

Reputation: 42903

I think it should be either:

def confirmation_token=(token)
    @confirmation = Booking.find_by_confirmation_token(token)
end

Or you should uncomment attr_accessible :confirmation or define #confirmation and #confirmation=.

Upvotes: 2

Related Questions