CODEWITHSUNDEEP
javascriptnode.jsmongoose
Nick Parsons
Nick Parsons

Reputation: 8607

Updating document within find

I'm having issues updating a document from within a find using Mongoose. The issue is only when I attempt to overwrite the document with an object (e.g doc = req.body). I am however able to directly set properties of the original document to a specific string (e.g. doc.name = 'jason borne';).

I've verified that res.body is an object, so I don't see why I'm unable to set it this way.

Client.findById(req.params.client_id, function (err, client) {

    if (err)
        return next(new restify.InternalError(err));

    // client.name = 'jason borne';

            client = req.body;

    client.save(function(err) {

        if (err)
            return next(new restify.InternalError(err));

        res.send(client);

    });

});

When attempting to set the doc to an object, I receive the error:

TypeError: Object # has no method 'save'

I'm aware that I can do an update with a simple Client.update(...) command, however this method does not allow my schema middleware or validation to run (which is notated in the Mongoose documentation).

Any thoughts? I'm new to Node, and Mongoose.

Upvotes: 1

Views: 138

Answers (2)

soulcheck
soulcheck

Reputation: 36767

The symptoms you're now getting are caused by the fact that you're replacing a mogoose model object (with methods like save, find, etc), by a simple json object parsed from your body, which is missing save.

Try doing an update instead of find/save.

 Client.update({_id: req.params.client_id}, {$set : req.body}, function(err) {...});

Or try to merge your req.body to the client object.

Upvotes: 2

JohnnyHK
JohnnyHK

Reputation: 311835

You need to use something like underscore's extend method to copy the properties of req.body into the client object instead of just re-pointing client to req.body as you are now.

var _ = require('underscore');
Client.findById(req.params.client_id, function (err, client) {

    if (err)
        return next(new restify.InternalError(err));

    _.extend(client, req.body);
    client.save(function(err) {
        if (err)
            return next(new restify.InternalError(err));
        res.send(client);
    });
});

Upvotes: 2

Related Questions