CODEWITHSUNDEEP
c#file-iofilesystemsisolatedstorage
fin
fin

Reputation: 1303

Is it considered good/acceptable practice to save a file in the temporary directory?

I am developing a WinForms application using C# 3.5. I have a requirement to save a file on a temporary basis. Let's just say, for arguments sake, that's it's for a short duration of time while the user is viewing a particular tab on the app. After the user navigates away from the tab I am free to delete this file. Each time the user navigates to the tab(which is typically only done once), the file will be created(using a GUID name).

To get to my question - is it considered good practice to save a file to the temp directory? I'll be using the following logic:

Path.GetTempFileName();

My intention would be to create the file and leave it without deleting it. I'm going to assume here that the Windows OS cleans up the temp directory at some interval based on % of available space remaining.

Note: I had considered using the IsolatedStorage option to create the file and manually delete the file when I was finished using it i.e. when the user navigates away from the tab. However, it's not going so well as I have a requirement to get the Absolute or Relative path to the file and this does not appear to be an straight-forward/safe chore when interacting with IsolatedStorage. My opinion is that it's just not designed to allow this.

Upvotes: 6

Views: 2745

Answers (4)

Alex Filipovici
Alex Filipovici

Reputation: 32541

In my opinion, it's a better practice to actually delete the temporary files when you don't need them. Consider the following remarks from Path.GetTempFileName() Method:

The GetTempFileName method will raise an IOException if it is used to create more than 65535 files without deleting previous temporary files.

The GetTempFileName method will raise an IOException if no unique temporary file name is available. To resolve this error, delete all unneeded temporary files.

Also, you should beaware about the following hotfix for Windows 7 and Windows Server 2008 R2.

Upvotes: 4

elevenThousand_dB
elevenThousand_dB

Reputation: 145

Go ahead and save there, but clean up when you're done (closing the program). Keeping them until the end also allows re-use.

Upvotes: 2

StarPilot
StarPilot

Reputation: 2272

Creating temp files in the temp directory is fine. It is considered good practice to clean up any temporary file when you are done using it.

Remember that temp files shouldn't persist any data you need on a long term basis (defined as across user sessions). Exaples of data needed "long term" are user settings or a saved data file.

Upvotes: 3

user1778205
user1778205

Reputation: 73

I write temp files quite frequently. In my humble opionion the key is to clean up after one self by deleting unneeded temp files.

Upvotes: 5

Related Questions