CODEWITHSUNDEEP
mysqltransactionsinnodbtable-locking
Vyktor
Vyktor

Reputation: 20997

SELECT ... FOR UPDATE from one table in multiple threads

I need a little help with SELECT FOR UPDATE (resp. LOCK IN SHARE MODE).

I have a table with around 400 000 records and I need to run two different processing functions on each row.

The table structure is appropriately this:

data (
    `id`,
    `mtime`,  -- When was data1 set last
    `data1`,
    `data2` DEFAULT NULL,
    `priority1`,
    `priority2`,
    PRIMARY KEY `id`,
    INDEX (`mtime`),
    FOREIGN KEY ON `data2`
)

Functions are a little different:

They shouldn't modify the same row at the same time, but the select may return one row in both of them (priority1 and priority2 have different values) and it's okay for transaction to wait if that's the case (and I'd expect that this would be the only case when it'll block).

I'm selecting data based on following queries:

-- For the first function - not processed first, then the oldest,
-- the same age goes based on priority
SELECT id FROM data ORDER BY mtime IS NULL DESC, mtime, priority1 LIMIT 250 FOR UPDATE;

-- For the second function - only processed not processed order by priority
SELECT if FROM data ORDER BY priority2 WHERE data2 IS NULL LIMIT 50 FOR UPDATE;

But what I am experiencing is that every time only one query returns at the time.

So my questions are:

Upvotes: 7

Views: 4503

Answers (2)

Shreyas Shinde
Shreyas Shinde

Reputation: 1

All points in accepted answer seem fine except below 2 points: "whatever was going to be returned by the Select will be the rows that get locked." & "Can indexes and keys cause any issues? but they shouldn't cause any issues with obtaining a lock."

Instead all the rows which are internally read by DB during deciding which rows to select and return will be locked. For example below query will lock all rows of the table but might select and return only few rows: select * from table where non_primary_non_indexed_column = ? for update Since there is no index, DB will have to read the entire table to search for your desired row and hence lock entire table.

If you want to lock only one row either you need to specify its primary key or an indexed column in the where clause. Thus indexing becomes very important in case of locking only the appropriate rows.

This is a good reference - https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html

Upvotes: 0

Andrew McGrath
Andrew McGrath

Reputation: 106

Key things to check for before getting much further:

  • Ensure the table engine is InnoDB, otherwise "for update" isn't going to lock the row, as there will be no transactions.
  • Make sure you're using the "for update" feature correctly. If you select something for update, it's locked to that transaction. While other transactions may be able to read the row, it can't be selected for update, updated or deleted by any other transaction until the lock is released by the original locking transaction.
  • To keep things clean, try explicitly starting a transaction using "START TRANSACTION", run your select "for update", do whatever you're going to do to the records that are returned, and finish up by explicitly executing a "COMMIT" to close out the transaction.

Order and limit will have no impact on the issue you're experiencing as far as I can tell, whatever was going to be returned by the Select will be the rows that get locked.

To answer your questions:

  1. Is it possible to acquire two separate locks in two separate transactions on separate bunch of rows (in the same table)?
    Yes, but not on the same rows. Locks can only exist at the row level in one transaction at a time.
  2. Do I have that many collisions between first and second query (I have troubles debugging that, any hint on how to debug SELECT ... FROM (SELECT ...) WHERE ... IN (SELECT) would be appreciated )?
    There could be a short period where the row lock is being calculated, which will delay the second query, however unless you're running many hundreds of these select for updates at once, it shouldn't cause you any significant or noticable delays.
  3. Can ORDER BY ... LIMIT ... cause any issues? Not in my experience. They should work just as they always would on a normal select statement.
  4. Can indexes and keys cause any issues?
    Indexes should exist as always to ensure sufficient performance, but they shouldn't cause any issues with obtaining a lock.

Upvotes: 4

Related Questions