CODEWITHSUNDEEP
android
teekib
teekib

Reputation: 2821

OntouchListener is not working properly

Iam trying to apply onTouchListener but iam running into few code problems,without switchcase it is working , when applying switch case its not, below is my code, with switch case code below

 if (phoneNo != null && !phoneNo.equals("")
                    && !phoneNo.equalsIgnoreCase("null")) {
                textPhone.setText(phoneNo);
                textPhone.setVisibility(View.VISIBLE);
                phImage.setVisibility(View.VISIBLE);

                phImage.setImageResource(R.drawable.phone);
                phImage.setTag(phoneNo);

                phImage.setOnTouchListener(new OnTouchListener() {



                    @Override
                    public boolean onTouch(View v, MotionEvent event) {
                        switch (event.getAction()) {
                        case MotionEvent.ACTION_DOWN: {
                        String phone = (String) ((ImageView) v).getTag();
                        Log.d(TAG, "onTouch phone--" + phone);
                        utils.dailPhone(v.getContext(), phone);
                        return false;
                    }
                        }}

                 else {
                phImage.setVisibility(View.GONE);
                textPhone.setVisibility(View.GONE);

            }
                break;
                    case MotionEvent.ACTION_MOVE:
                        break;
                    case MotionEvent.ACTION_UP:
                        break;
                    }

                    return false;
                }

without swithcase below

phImage.setOnTouchListener(new OnTouchListener() {



                @Override
                public boolean onTouch(View v, MotionEvent event) {
                    String phone = (String) ((ImageView) v).getTag();
                    Log.d(TAG, "onTouch phone--" + phone);
                    utils.dailPhone(v.getContext(), phone);
                    return false;
                }
            });

        } else {
            phImage.setVisibility(View.GONE);
            textPhone.setVisibility(View.GONE);

        }

Upvotes: 0

Views: 234

Answers (1)

Raghav Sood
Raghav Sood

Reputation: 82583

Your switch-case syntax is completely wrong. Try something like:

public boolean onTouch(MotionEvent event) {
    int eventaction = event.getAction();

    switch (eventaction) {
        case MotionEvent.ACTION_DOWN: 
            // finger touches the screen
            String phone = (String) ((ImageView) v).getTag();
            Log.d(TAG, "onTouch phone--" + phone);
            utils.dailPhone(v.getContext(), phone);
            return false;
            break;

        case MotionEvent.ACTION_MOVE:
            // finger moves on the screen
            break;

        case MotionEvent.ACTION_UP:   
            // finger leaves the screen
            break;
    }

    // tell the system that we handled the event and no further processing is required
    return true; 
}

Upvotes: 2

Related Questions