andy
andy

Reputation: 2409

Dynamic computed properties in Ember.JS deprecated?

I am trying to make an ember application. I have a computed property and the controller looks like this:

// The Controller

Todos.Controller = Ember.Controller.create({

    // ** SNIP ** //

    countCompleted: function()
    {
        return this.get('todos').filterProperty('completed', true).length
    }.property(),
});

// The View

{{Todos.Controller.countCompleted.property}} Items Left

Now the tutorial I'm following is using an older version of Ember.JS. I've fixed every error but this:

Uncaught Error: assertion failed: Ember.Object.create no longer supports defining computed properties.

What's the alternative way to do this?

Upvotes: 9

Views: 5113

Answers (2)

rart
rart

Reputation: 21

It also seems to work ok if you do a reopen:

Todos.todosController = Ember.Controller.create({
    // ** SNIP ** //
});

Todos.todosController.reopen({
    countCompleted: function() {
        return this.get('todos').filterProperty('completed', true).length
    }.property(),
});

Upvotes: 2

DF_
DF_

Reputation: 3973

The computed property is only deprecated on the create() function of an object. If you wish to create a computed property, then you must first extend() the object, and then create() it.

For example:

// The Controller

Todos.TodosController = Ember.Controller.extend({

    // ** SNIP ** //

    countCompleted: function()
    {
        return this.get('todos').filterProperty('completed', true).length
    }.property(),
});

// Note the lower case 't' here. We've made a new object
Todos.todosController = Todos.TodosController.create();

// The View


// We reference the created object here (note the lower case 't' in 'todosController')
{{Todos.todosController .countCompleted.property}} Items Left

Upvotes: 10

Related Questions