CODEWITHSUNDEEP
c++string.h
Bobby Tables
Bobby Tables

Reputation: 301

declaration is incompatible, beginner c++

I just need a little help on this assignment. I have to redefine operators to work with strings. I'm starting with the == operator and I have it declared in my header file, however when I go to define the function in my cpp file, it says it's incompatible with the declared function. It's probably a stupid mistake, I just don't understand this sometimes.

string.h header file

    #pragma once

    #include <iostream>
    #include <string>
    using namespace std;

    #define NOT_FOUND -1

   // C++ String class that encapsulates an ASCII C-string
class String
{
 public:
// Default constructor
String();

// MUST HAVE: Copy-constructor that performs deep copy
String(const String& source);

// Init-constructor to initialize this String with a C-string
String(const char* text);

// Init constructor, allocates this String to hold the size characters
String(int size);

// Destructor
~String();

bool& compareTo(const String& cmp1);
// Assignment operator to perform deep copy
String& operator = (const String& source);

// Assignment operator to assign a C-string to this String
String& operator = (const char* text);

// Returns a reference to a single character from this String
char& operator [] (int index) const;

// Comparison operators
bool operator == (const String& compareTo) const;

string.cpp file

    #include "string.h"
#include <string>
#include <sstream>

using namespace std;

// Default constructor
String::String()
{
Text = NULL;
}

// MUST HAVE: Copy-constructor that performs deep copy
String::String(const String& source)
{
Text = NULL;
// Call the assignment operator to perform deep copy
*this = source;
}

// Init-constructor to initialize this String with a C-string
String::String(const char* text)
{
Text = NULL;
// Call the assignment operator to perform deep copy
*this = text;
}

// Init constructor, allocates this String to hold the size characters
String::String(int size)
{
Text = new char[size];
}

// Destructor
String::~String()
{
delete[] Text;
}

// Assignment operator to perform deep copy
String& String::operator = (const String& source)
{  
// Call the other assigment operator to perform deep copy
*this = source.Text;
return *this;
}

// Assignment operator to assign a C-string to this String
String& String::operator = (const char* text)
{
// Ddispose of old Text
delete[] Text;

// +1 accounts for NULL-terminator
int trueLength = GetLength(text) + 1;

// Dynamically allocate characters on heap
Text = new char[trueLength];

// Copy all characters from source to Text; +1 accounts for NULL-terminator
for ( int i = 0; i < trueLength; i++ )
    Text[i] = text[i];

return *this;
}

***bool& String::operator ==(string cmp2)***
{
};

Upvotes: 0

Views: 2694

Answers (1)

billz
billz

Reputation: 45410

Your compareTo declaration has const while definition has no const, which means they have definition has different signature with declaration:

bool& compareTo(const String& cmp1);
                ^^^
bool& String::compareTo(string cmp2)
{
};

BTW, why does your compareTo return bool& ?

Also should avoid using namespace std; in any header files. see why-is-using-namespace-std-considered-a-bad-practice-in-c

Upvotes: 2

Related Questions