CODEWITHSUNDEEP
javascriptframeworksangularjs
Vural
Vural

Reputation: 8748

Why angularJs updates all elements of an array/hashmap, if only one changed?

I have a simple hashmap and a simple method which displays the status in text, but when I update only 1 user-status, all of them are getting updated (function is called for all users). Is there a way to update only one element and not all of them?

Example code is here, just see what happens in console when you click on the "Change Status" button.

HTML:

<div ng-app="myApp">
  <div ng-controller="Ctrl">
    <div class="user-panel" ng-repeat = "(id, user) in _users">
        Status: 
        <span class="user-status{{user.status}}">
            {{getStatusInText(user.status)}}
        </span>
        <hr>
        <div class="toLeft">(<b>{{id}}</b>) {{user.name}}</div>
        <div class="toRight">
            <button ng-click="changeUserStatus(id, '1')">Change Status</button>
        </div>
       <div class="clear"></div>
    </div>
  </div>    
</div>

AngularJS:

var app = angular.module('myApp', []);

function Ctrl($scope) {
    $scope._users = {"123":{"name":"test","status":"0"}, "124":{"name":"test2", "status":"0"},"125":{"name":"test2", "status":"0"}};

    $scope.getStatusInText = function(status) {
        console.log("CALLED: " + status);
        return (status === "1") ? "online" : "offline";
    }

    $scope.changeUserStatus = function(uId, status) {
        $scope._users[uId].status = status;

    }
}

And the fiddle for above example:

http://jsfiddle.net/ztVnj/3

another example with iteration, which is called everytime with the getStatusInText function.

http://jsfiddle.net/ztVnj/4/

Upvotes: 4

Views: 10899

Answers (1)

Alex Osborn
Alex Osborn

Reputation: 9851

Updated example: http://jsfiddle.net/ztVnj/5/

Theory here:

Move the expensive operation outside the hashmap, and manually control the update. As already mentioned, if the hashmap is changed at all, the whole ng-repeat is redrawn.

Changes:

Binding to $scope, add an array to map status values to ids.

$scope._users = {"123":{"name":"test","status":"0"}, "124":{"name":"test2", "status":"0"},"125":{"name":"test2", "status":"0"}};
$scope._userStatus = [];

Change template to look up this array instead:

Status: <span class="user-status{{user.status}}">{{_userStatus[id]}}</span>

Update the changeStatus function to be the only place the status text is updated, and then perform one initial iteration at the beginning.

$scope.changeUserStatus = function(uId, status) {
    console.log("Button Clicked.");
    $scope._userStatus[uId] = $scope.getStatusInText(status);
}

angular.forEach($scope._users, function(user, uId) {
    $scope._userStatus[uId] = $scope.getStatusInText(user.status);
});

Upvotes: 5

Related Questions