CODEWITHSUNDEEP
javaarrays
user2092325
user2092325

Reputation: 29

User input arrays

I am trying to create a program that sorts user inputted integers from greatest to least. Also I need to find a way to print the maximum and minimum numbers. The code was sorting fine when I had defined values but now that I have switched it to user input it sends back "0"s for some reason. This is my code 

import java.util.Scanner;
public class SortInteger {

        public static void main(String [] args)
        {
            Scanner input = new Scanner(System.in); 
            System.out.println("Please input three numbers");
            int num = input.nextInt();
            int number [] = new int [num];  //Sorting Array
            int temp;

            boolean correct = false; // Forces the sorting to continue till the numbers are in order

            while(correct ==false){
                correct = true;
            for(int i = 0; i>number.length-1; i++ ){

                if(number [i] >  number [i+1]){
                    temp = number [i+1];
                    number [i+1] = number[i];
                    number[i]= temp;
                    correct = false;

                }
            }
        }
                for(int i = 0; i<number.length-1; i++){   //outputs the array to user
                    System.out.println(number[i]);

                }

        }

    }

Upvotes: 1

Views: 3248

Answers (3)

Ulises
Ulises

Reputation: 13429

As others pointed out you need to populate your array with multiple values, currently you are requesting only one int.

Also, are you sure that works? Should't your first for loop read:

for(int i = 0; i<number.length-1; i++ )

Instead of:

for(int i = 0; i>number.length-1; i++ )

On a side note, it looks to me that your sorting algorithm is O(n2) you may want to look into mergesort and quicksort.

Upvotes: 1

Arpit
Arpit

Reputation: 12797

you have taken only one number 

int num = input.nextInt();

and you are using it for array size :

     int number [] = new int [num];

but in rest of the code you haven't taken any input so your array is empty.

Code::

import java.util.*;
class test{
 public static void main(String [] args)
    {
        Scanner input = new Scanner(System.in); 
        System.out.println("Please input three numbers");
        int num1 = input.nextInt();
        int num2 = input.nextInt();
        int num3 = input.nextInt();
    int number [] = {num1,num2,num3};  //Sorting Array
    int temp;

    boolean correct = false; // Forces the sorting to continue till the numbers are in order

    while(correct ==false){
        correct = true;
    for(int i = 0; i<number.length-1; i++ ){

        if(number [i] >  number [i+1]){
            temp = number [i+1];
            number [i+1] = number[i];
            number[i]= temp;
            correct = false;

        }
    }
}
        for(int i = 0; i<number.length; i++){   //outputs the array to user
            System.out.println(number[i]);

        }

}}

Output::

Please input three numbers
1
5
4
1
4
5

Upvotes: 2

PermGenError
PermGenError

Reputation: 46428

you are only initializing your array. you never initialized your array with elements, thus your array elements get default values. 

        System.out.println("Please enter size");
        int num = input.nextInt();
        int number [] = new int [num];  //Sorting Array

         for(int i=0; i<number.length; i++){
               System.out.println("Please enter element at index " + i);
              number[i] = input.nextInt()
         }

Upvotes: 2

Related Questions