CODEWITHSUNDEEP
validationcakephp
Benjamin Allison
Benjamin Allison

Reputation: 2154

Vallidation errors with saveAll in CakePHP

I have a list of User records that I'm saving at one time (the form is populated from an uploaded CSV).

Everything seems to be working fine, and my validation rules are being honoured, but one thing that's eluding me are the specific validation error messages.

I get the general validation error (if say, a field that is supposed to be unique is not), but I'm not getting an error on the specific field to let the user know what the actual problem is.

Is this a bug, or is there something wrong with my Code? Here's the action from my Controller (fwiw I'm passing the CSV data to this action from another action, hence the snippet at the beginning):

public function finalizeCsv() {
    if ( isset($this->request->params['named']['csvData']) ) {
        $csvData = unserialize( $this->request->params['named']['csvData'] );
    } else {
        $csvData = $this->request->data;
    }
    $this->set('users', $csvData);
    if ($this->request->is('get')) {
        $this->request->data = $csvData;
    }
    if ($this->request->is('post') || $this->request->is('put')) {
        if ($this->User->saveAll($this->request->data)) {
            $this->Session->setFlash('Users added!', 'default', array('class' => 'success'));
            $this->redirect(array('action' => 'index'));
        } else {
            $this->Session->setFlash('There were errors with your data.');
        }
    }
}

Upvotes: 0

Views: 1518

Answers (1)

Swayok
Swayok

Reputation: 463

For unique fields add a validation rule

'field_name' => array(
    'rule' => 'isUnique',
    'required' => 'create'
),

Next - when you get a error you will need to review $this->User->validationErrors. There will be many arrays inside - 1 for each created record. Loop through them, collect errors and send them to $this->Session->setFlash().
Also you better wrap $this->User->saveAll($this->request->data) into transaction if you're using InnoDB or other engine that supports transactions. On error - do rollback and try again. 

$ds = $this->User->getDataSource();
$ds->begin();
// > saving here < //
$ds->commit(); //< on success
$ds->rollback(); //< on error

Upvotes: 1

Related Questions