CODEWITHSUNDEEP
javascript
Matthew Paxman
Matthew Paxman

Reputation: 247

Removing %20 from URL parameters

I know you need to use some variant of decodeURIComponent() to do something like this, but since I'm still fairly new to coding and using some code I found on the net for my purposes, I'm not sure how to go about changing it to suit my needs.

What I have is a function that gets each URL parameter I need out of the URL (of which there are many). I have to use these variables for other functions as parameters and also to display on the page, and I can't get the %20's to disappear.

function getUrlVars() {
            var vars = {};
            parts = window.location.href.replace(/[?&]+([^=&]+)=([^&]*)/gi, function(m,key,value) {
            vars[key] = value;
            });
            return vars;
        }

Where I get each variable using:

var markname = getUrlVars()["mname"];

I've tried to put decodeURIComponent() in different places in that function, but I can't seem to get it to work. I'm also not sure if it needs to use value or vars.

value = decodeURIComponent(value);

Or something like that...

Any help would be appreciated! Thanks!

Upvotes: 7

Views: 25118

Answers (3)

Daniel
Daniel

Reputation: 71

simply do this ("your string here").replaceAll(" ", "-")

Upvotes: 0

Rahul Tathod
Rahul Tathod

Reputation: 348

when you pass the url use str_replace(" ","-",$name) and decode it by str_replace("-"," ",$p->property_name)

it will remove space and add - in the url

Upvotes: 1

Bergi
Bergi

Reputation: 664444

decodeURIComponent as you posted should work fine. You might as well replace plus signs with spaces, and don't forget to decode the key as well:

function getUrlVars() {
    var url = window.location.href,
        vars = {};
    url.replace(/[?&]+([^=&]+)=([^&]*)/gi, function(m, key, value) {
         key = decodeURIComponent(key);
         value = decodeURIComponent(value);
         vars[key] = value;
    });
    return vars;
}

Upvotes: 6

Related Questions