CODEWITHSUNDEEP
c++c++11
Andrew Tomazos
Andrew Tomazos

Reputation: 68618

Getting "source type is not polymorphic" when trying to use dynamic_cast

struct A {};

struct B : A {};

int main()
{
    A* a = new B();

    B* b = dynamic_cast<B*>(a);
}

gives:

cannot dynamic_cast 'a' (of type 'struct A*') to type 'struct B*' (source type is not polymorphic)

How can I make A polymorphic? I want to safely cast it to B.

(One way is to add a dummy virtual function, but is there a better way?)

Upvotes: 111

Views: 61462

Answers (3)

Andy Prowl
Andy Prowl

Reputation: 126422

As your compiler says, your type A is not polymorphic. You should add a virtual function to it. For instance, a virtual destructor could be a good choice:

struct A { virtual ~A() { } };
//         ^^^^^^^ This makes A a polymorphic type

struct B : A {};

int main()
{
    A* a = new B();

    B* b = dynamic_cast<B*>(a); // Should work now
}

Upvotes: 8

juanchopanza
juanchopanza

Reputation: 227390

You need to make A polymorphic, which you can do by adding a virtual destructor or any virtual function:

struct A {
  virtual ~A() = default;
};

or, before C++11,

struct A {
  virtual ~A() {}
};

Note that a polymorphic type should have a virtual destructor anyway, if you intend to safely call delete on instances of a derived type via a pointer to the base.

Upvotes: 163

Luchian Grigore
Luchian Grigore

Reputation: 258568

You need at least a virtual function - typically, if no others are suitable, the destructor:

struct A {
   virtual ~A() {}
};

Upvotes: 19

Related Questions