CODEWITHSUNDEEP
pythonmultithreadingqueue
Yoan Arnaudov
Yoan Arnaudov

Reputation: 4164

Python threads and queue example

I'm new to python (I come from PHP), I've been reading tutorials and trying things for a couple of days but I can't understand this queue example (http://docs.python.org/2/library/queue.html) 

def worker():
    while True:
        item = q.get()
        do_work(item)
        q.task_done()

q = Queue()
for i in range(num_worker_threads):
     t = Thread(target=worker)
     t.daemon = True
     t.start()

for item in source():
    q.put(item)

q.join()       # block until all tasks are done

The thing I don't understand is how the worker thread completes and exists. I've read q.get() blocks until an item is available, so if all items are processed and none is left in the queue why q.get() doesn't block forever?

Upvotes: 15

Views: 23086

Answers (2)

Anton Danylchenko
Anton Danylchenko

Reputation: 2358

I have had the same problem. When all threads completed, I saw "sleeping threads" in process list (use top -H -p <pid> where <pid> is process id from ps aux | grep python with your script).

I solved this problem by replacing "infinite loop" while True to while not q.empty():.

It fixed the problem with "sleeping threads".

def worker():
    while not q.empty():
        item = q.get()
        do_work(item)
        q.task_done()

q = Queue()
for i in range(num_worker_threads):
     t = Thread(target=worker)
     t.daemon = True
     t.start()

for item in source():
    q.put(item)

q.join()       # block until all tasks are done

Upvotes: -3

Pavel Anossov
Pavel Anossov

Reputation: 62948

Threads do not exit normally in this code (they are indeed blocked when the queue is empty). The program doesn't wait for them because they're daemon threads.

The program doesn't exit immediately and doesn't block forever because of q.join and q.task_done calls.

The count of unfinished tasks goes up whenever an item is added to the queue. The count goes down whenever a consumer thread calls task_done() to indicate that the item was retrieved and all work on it is complete. When the count of unfinished tasks drops to zero, join() unblocks, and the program exists without waiting for daemon threads.

Upvotes: 9

Related Questions