CODEWITHSUNDEEP
c#linqhtml-agility-pack
user1590636
user1590636

Reputation: 1194

LINQ Where Syntax

I've the following LINQ to fill a datatable from html <tr> tags with the help of HTMLAgilityPack, each tag has one attribute and i need to ignore the innertext of that tag if the attribute value is "rating-col".

nodes.Skip(1)
.Select(
tr => tr.Elements("td").
    Select(td => td.InnerText.
        Where(td.Attributes[0].Value != "rating-col")).
        ToArray()).
        ToList().
        ForEach(row => dt.Rows.Add(row));

without the Where clause things work fine, what am i doing wrong inside the Where clause?

Upvotes: 2

Views: 9186

Answers (2)

Joel Coehoorn
Joel Coehoorn

Reputation: 415690

Looks like you were missing a lambda and that one of the Selects was out of order. Also, there was no reason for ToList() or ForEach() here. Your ToList() call made things slower and forced you to use more memory. The only reason you need it is to get at the ForEach() extension, and that doesn't really save you anything here over a normal foreach loop. Plus, while I'm not an expert in that area, I'm given to understand that the ForEach() extension is poor functional style, because it almost assumes you're causing side effects (a big functional no-no). Since linq is heavily inspired by the functional programming paradigm, I try to pay attention to such things.

foreach (var row in nodes.Skip(1)
     .Select(tr => tr.Elements("td")
         .Where(td => td.Attributes[0].Value != "rating-col")
         .Select(td => td.InnerText)
         .ToArray()))
{
    dt.Rows.Add(row);
}

Upvotes: 4

IAbstract
IAbstract

Reputation: 19881

Where(td.Attributes[0].Value != "rating-col")) should have a lambda in it ...such as:

Where(c => c.Attributes[0].Value != "rating-col"))

Upvotes: 5

Related Questions