CODEWITHSUNDEEP
flashactionscript-3stringconcatenation
Andy Li
Andy Li

Reputation: 6034

String concatenation is extremly slow when input is large

Things like the code below is super slow:

var str:String = ""
for (var i:Number = 0 ; i<1000000000000000000 ; ++i) {
    str += "someLongLongLongLongLongLongLongLongLongString";
}

There is StringBuilder in Java but seems there is no equivalent for AS. So, how do you guys handle large strings concatenation?

Update:

Thanks for everyone's answer!

I've just coded my own testing program. Using += is already the fastest... What is slow is whan put it on a TextArea...

I've up voted for most of you as the advices make sense :) although my test result show that seems my question is somewhat problematic since I ask for something better then what is already the best :P

Upvotes: 3

Views: 2746

Answers (5)

paxdiablo
paxdiablo

Reputation: 881293

Yes, that would be slow, even with a StringBuilder. My question is: why are you trying to create a string 46 exabytes in size?

At some point, a more conventional external-storage (i.e., on-disk) method becomes a good idea but you seem to have passed even that point (based on the disk arrays in common use today).

I don't generally have this problem since I tend not to use strings for storing such huge things. String are generally meant for somewhat smaller objects. What you have there is a sizable data warehouse, not a name or address field :-)

Upvotes: 7

back2dos
back2dos

Reputation: 15623

you are conducting type abuse here ... :D ... on AVM2, strings are meant for text representation ... they are always unicode, which is why they need more than 2 bytes per char ... so they are not suitable for storing a i-will-make-your-heap-explode sized ascii sequence ... if you really want to manipulate a sh*tload of data, then go for flash.utils::ByteArray ... not that it is particularly faster, but it is semantically more correct and has a lower memory footprint ... plus it has native compression methods, which is what i'd highly recomend in your case ... :P

Upvotes: 2

Joel Hooks
Joel Hooks

Reputation: 6565

––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
performancetests.Strings (1 iterations)                                 
Player version: MAC 10,0,32,18 (debug)
––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
method...................................................ttl ms...avg ms
stringsWithConcatMethod                                   17555 17555.00
stringsWithPlusConcat                                      4972  4972.00
––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––

I'm not a masochist so I just used a 10000000 iteration loop on this:

var str:String = ""
for (var i:Number = 0 ; i<10000000 ; ++i) {
    str += "someLongLongLongLongLongLongLongLongLongString";
}

versus:

var str:String = ""
for (var i:Number = 0 ; i<10000000 ; ++i) {
    str = str.concat("someLongLongLongLongLongLongLongLongLongString");
}

Using Grant Skinner's AS3 Performance Test Harness. The String::concat method is even slower, though given your conditions as3 is likely to just be sloooow. (1 iteration in the result is 1 time going through the 10000000 iteration loops). I was fairly surprised by the result. I thought concat would be faster.

Upvotes: 3

unwind
unwind

Reputation: 399793

Two things generally make operations like these slow:

  • The string grows out of the memory allocated for it, so it has to be re-allocated. This involves the heap memory manager, and copying the contents. As the contents grows, this means it is copied around a lot, and that the memory system has to work pretty hard.
  • If the string is not stored in a way that means its length is available as a O(1) operation, concatenation first has to step through the entire string to find the length, i.e. where to start concatenating. The means each single concatenation takes time proportional to the length of the target string.

I'm sure at least one of these is hitting you (the latter might not, not sure how strings are represented internally in ActionScript).

Upvotes: 2

Blixt
Blixt

Reputation: 50169

I can't say I'm experienced with ActionScript, but for ECMAScript in general, I've found that arrays can help speed up string concatenation (JavaScript example follows):

var sb = [];
for (var i = 0; i < 10000000000; i++) {
    sb.push('longlonglong');
    // In this particular case you can avoid a method call by doing:
    //sb[i] = 'longlonglong';
}
var str = sb.join('');

Upvotes: 5

Related Questions