CODEWITHSUNDEEP
asp.netentity-frameworkentity-framework-5
Mark Meisel
Mark Meisel

Reputation: 861

EF 5.0 Trouble updating entity which is already tracked

I'll preface this question with the following: I know there are a million posts on the internet about the old "An object with the same key already exists in the ObjectStateManager" issue. My scenario is a bit more complicated, I think.

I have a UnitOfWork class which creates a DbContext and passes it to any repository which is called. The pattern I'm using closely follows the Unit of Work tutorial on the ASP.NET site. Unlike the tutorial, my repositories take in Business entities, map them to data entities, and perform some CRUD action. My Business logic only works with Business entities. Here is what I'm trying to do in a sample Business Manager class:

_unitOfWork.Repository.Add(entity);
_unitOfWork.Save(); // context.SaveChanges() under the hood

...Perform some operations on the model...

_unitOfWork.Repository.Update(entity);
_unitOfWork.Save();

Here is a sample Update method from the repository:

public virtual void Update(entity)
{
  var dataEntity = // map from business entity to data;

  _context.Entry(dataEntity).State = EntityState.Modified;
}

It obviously fails on the last line. Here is where my confusion sets in:

The Update method in the repository needs to handle two scenarios: 1) updating an entity which is not currently tracked by the context, and 2) updating an entity which IS currently tracked by the context. The second piece is what I'm struggling with.

Any help or insight is appreciated.

Thanks!

Upvotes: 1

Views: 296

Answers (2)

Gert Arnold
Gert Arnold

Reputation: 109080

This means that there already is an object attached to the context with the same key as the new dataEntity. The existing object and the new entity both represent the same entry in the database but they are two different objects.

This may indicate that the lifespan of your _context is too long, but that's hard to judge from your code. It is certain though that the context was previously used to fetch an entity from the database that is subsequently duplicated by var dataEntity = ....

You may have to shorten the lifespan of the context, I can't tell. If you think it's OK you may want to use the Local collection to check whether the entity is already there. That will save the database round trip that Find may still make.

Upvotes: 1

Mark Meisel
Mark Meisel

Reputation: 861

I found a hybrid solution which appears to work:

public virtual void Update(TB entity)
        {
            var dataEntity = Mapper.Map<TB, TD>(entity);

            var pkey = _dbSet.Create().GetType().GetProperty("Id").GetValue(dataEntity);
            var entry = _context.Entry(dataEntity);

            if (entry.State == EntityState.Detached)
            {
                var attachedEntity = _dbSet.Find(pkey);

                if (attachedEntity != null)
                {
                    var attachedEntry = _context.Entry(attachedEntity);
                    attachedEntry.CurrentValues.SetValues(dataEntity);
                }
                else
                {
                    entry.State = EntityState.Modified;
                }
            }
            else
            {
                entry.State = EntityState.Modified;
            }
        }

Upvotes: 0

Related Questions