AndiM
AndiM

Reputation: 2188

Save Bitmap into File and return File having bitmap image

I have a problem to save Bitmaps into files. My method is like this:

private File savebitmap(Bitmap bmp) {
    String extStorageDirectory = Environment.getExternalStorageDirectory()
            .toString();
    OutputStream outStream = null;

    File file = new File(bmp + ".png");
    if (file.exists()) {
        file.delete();
        file = new File(extStorageDirectory, bmp + ".png");
        Log.e("file exist", "" + file + ",Bitmap= " + bmp);
    }
    try {
        outStream = new FileOutputStream(file);
        bmp.compress(Bitmap.CompressFormat.PNG, 100, outStream);
        outStream.flush();
        outStream.close();
    } catch (Exception e) {
        e.printStackTrace();
    }
    Log.e("file", "" + file);
    return file;

}

It gives me error of file.I am calling this method like this:

Drawable d = iv.getDrawable();
Bitmap bitmap = ((BitmapDrawable) d).getBitmap();
File file = savebitmap(bitmap);

Please help me...

Upvotes: 17

Views: 53412

Answers (3)

Festus Tamakloe
Festus Tamakloe

Reputation: 11310

I try to make some corrections on your code I assume that you want to use filename instead of bitmap as parameter

 private File savebitmap(String filename) {
      String extStorageDirectory = Environment.getExternalStorageDirectory().toString();
      OutputStream outStream = null;

      File file = new File(filename + ".png");
      if (file.exists()) {
         file.delete();
         file = new File(extStorageDirectory, filename + ".png");
         Log.e("file exist", "" + file + ",Bitmap= " + filename);
      }
      try {
         // make a new bitmap from your file
         Bitmap bitmap = BitmapFactory.decodeFile(file.getName());

         outStream = new FileOutputStream(file);
         bitmap.compress(Bitmap.CompressFormat.PNG, 100, outStream);
         outStream.flush();
         outStream.close();
      } catch (Exception e) {
         e.printStackTrace();
      }
      Log.e("file", "" + file);
      return file;

   }

Upvotes: 35

greenapps
greenapps

Reputation: 11214

Change File file = new File(bmp + ".png"); to File file = new File(extStorageDirectory,"bmp.png"); like you did nearly the second time.

Upvotes: 0

Nirali
Nirali

Reputation: 13805

You can't write like this

 File file = new File(bmp + ".png");

and this line is also wrong

file = new File(extStorageDirectory, bmp + ".png");

You have to give string value and not bitmap.

 File file = new File(filename + ".png"); 

Upvotes: 2

Related Questions