CODEWITHSUNDEEP
emacslispelisp
user181548
user181548

Reputation:

Emacs lisp "shell-command-on-region"

In GNU Emacs, I want to run a program, figlet, on the currently selected text. I then want to comment the region which is produced.

I have figured out how to do it using the standard Emacs commands:

However, I have failed to work out how to write an Emacs lisp program to do all this. Here is my attempt:

(defun figlet-region () 
  (interactive)
  (push-mark)
  (shell-command-on-region "figlet")
  (comment-region (mark) (point))
  (pop-mark)
)

(global-set-key "\C-c\C-f" 'figlet-region)

Then C-<space>; M-x figlet-region produces garbage:

figlet-region: Wrong number of arguments: #[(start end command &optional output-buffer replace error-buffer display-error-buffer) "ÆÇÈ  
\"!É
'jÊ!j;j
0Wb
?Ë`Ì\"Í ÎQÎDRÎÉ!\"&
ffÏ )ãÐqÑ!#Ò#p=¬É$]d|e^|Íed ΠÎD¡ÎÉ!\"&â%&#qÉ$Á&%Ó *Í ÉØ#DÚ#É!\"&*#Ô!#ÕÖ×!8WrÐ!qd`Z'o   ØcÙÉ\"d'Zb)(Úp!)Û!*" [error-buffer small-temporary-file-directory temporary-file-directory exit-status error-file replace make-temp-file expand-file-name "scor" nil ...] 9 1945557 (let (string) (unless (mark) (error "The mark is not set now, so there is no region")) (setq string (read-from-minibuffer "Shell command on region: " nil nil nil (quote shell-command-history))) (list (region-beginning) (region-end) string current-prefix-arg current-prefix-arg shell-command-default-error-buffer t))], 1

Answer

(defun figlet-region (&optional b e) 
  (interactive "r")
  (shell-command-on-region b e "figlet" (current-buffer) t)
  (comment-region (mark) (point)))

(This is based on Trey Jackson's answer.)

Example (Lisp Interaction mode)

;;  _   _                 _        
;; | |_| |__   __ _ _ __ | | _____ 
;; | __| '_ \ / _` | '_ \| |/ / __|
;; | |_| | | | (_| | | | |   <\__ \
;;  \__|_| |_|\__,_|_| |_|_|\_\___/

Example (CPerl mode)

#  _   _                 _        
# | |_| |__   __ _ _ __ | | _____ 
# | __| '_ \ / _` | '_ \| |/ / __|
# | |_| | | | (_| | | | |   <\__ \
#  \__|_| |_|\__,_|_| |_|_|\_\___/

Upvotes: 23

Views: 8863

Answers (3)

sds
sds

Reputation: 60014

It is not a very good idea to use an interactive command like shell-command-on-region in a lisp program. You should use call-process-region instead:

(defun figlet-region (&optional b e) 
  (interactive "r")
  (call-process-region b e "figlet" t t)
  (comment-region (mark) (point)))

It should be more resilient against various user options.

Upvotes: 9

Trey Jackson
Trey Jackson

Reputation: 74430

I'm unsure what you're trying to accomplish with the pushing and popping of the marks, I believe you'd get the same functionality by doing this:

(defun figlet-region (&optional b e) 
  (interactive "r")
  (shell-command-on-region b e "figlet")
  (comment-region b e))

The argument to interactive tells Emacs to pass the region (point and mark) in as the first two arguments to the command.

Upvotes: 25

Bahbar
Bahbar

Reputation: 18015

Well, I'm not sure where the garbage is coming from, but the error itself is coming from shell-command-region. When used in elisp, it expects at least 3 arguments, START END and COMMAND.

Also, in general, it is bad practice to mess with the mark in functions. Here is what the doc of push-mark has to say on the subject:

Novice Emacs Lisp programmers often try to use the mark for the wrong purposes. See the documentation of `set-mark' for more information.

Upvotes: 5

Related Questions