CODEWITHSUNDEEP
phpmysql
Bob Dillen
Bob Dillen

Reputation: 11

Download files from MYSQL database

ok i got files uploading to my database alright. but having problems downloading files from the database, it shows as a link and when i click on the link nothing happens.

im still new to php so my code my not be perfect.

here is my upload file

 <?php

   require 'connect.php';
 ?>
 <form method="post" enctype="multipart/form-data">
 <table width="350" border="0" cellpadding="1" cellspacing="1" class="box">
 <tr>
 <td width="246">
<input type="hidden" name="MAX_FILE_SIZE" value="2000000">
<input name="userfile" type="file" id="userfile">
</td>
<td width="80"><input name="upload" type="submit" class="box" id="upload" value="                                        
</tr>
  </table>
  </form>


 <?php
if(isset($_POST['upload']) && $_FILES['userfile']['size'] > 0)
{
$fileName = $_FILES['userfile']['name'];
$tmpName  = $_FILES['userfile']['tmp_name'];
$fileType = $_FILES['userfile']['type'];
$fileSize = $_FILES['userfile']['size'];
$fp      = fopen($tmpName, 'r');
$content = fread($fp, filesize($tmpName));
$content = addslashes($content);
fclose($fp);
if(!get_magic_quotes_gpc())
{
$fileName = addslashes($fileName);
}
$query = "INSERT INTO upload (name, type, size, content) ".
"VALUES ('$fileName', '$fileType', '$fileSize', '$content')";
mysql_query($query) or die('Error, query failed');
echo "<br>File $fileName uploaded<br>";
}
?>



 Here is my download 


<?php
require 'connect.php';

   $query = "SELECT id, name FROM upload";
   $result = mysql_query($query) or die('Error, query failed');
   if(mysql_num_rows($result) == 0)
   {
    echo "Database is empty <br>";
   }
   else
   {
    while(list($id, $name) = mysql_fetch_array($result))
    {
   ?>
   <a href="download.php?id=<?php echo urlencode($id);?>"><?php echo urlencode($name);? ></a> <br>
   <?php
   }
   }
   exit;
  mysql_close()
   ?>
   <?php
   require 'connect.php';
    $query = "SELECT id, name FROM upload";
    if(isset($_GET['id']))
    {

    $id    = $_GET['id'];
    $query = "SELECT name, type, size, content " .
    "FROM upload WHERE id = '$id'";
     $result = mysql_query($query) or die('Error, query failed');
    list($name, $type, $size, $content) =  mysql_fetch_array($result);
    $content = $row['content'];
    header("Content-Disposition: attachment; filename=\"$filename\"");
    header("Content-type: $type");
    header("Content-length: $size");
    exit;
    print $content;
   ob_clean();
  flush();
    echo $content;
   }
    ?>

Upvotes: 0

Views: 17398

Answers (2)

hodl
hodl

Reputation: 1420

I scan thoroughly your code and here is the final answer.

<?php
    require 'connect.php';

    $query = "SELECT id, name FROM upload";
    $result = mysql_query($query) or die('Error, query failed');

    if(mysql_num_rows($result)==0){
        echo "Database is empty <br>";
    }
    else{
        while(list($id, $name) = mysql_fetch_array($result)){
            echo "<a href=\"download.php?id=\$id\">$name</a><br>";
        }
    }

    if(isset($_GET['id'])){
        $id    = $_GET['id'];   
        $query = "SELECT name, type, size, content FROM upload WHERE id = '$id'";       
        $result = mysql_query($query) or die('Error, query failed');
        list($name, $type, $size, $content) =  mysql_fetch_row($result);
        header("Content-Disposition: attachment; filename=\"$name\"");
        header("Content-type: $type");
        header("Content-length: $size");
        print $content;
    }
?>

Upvotes: 1

UnholyRanger
UnholyRanger

Reputation: 1971

In your download.php you make the links and exit. This means you will not go any further than your exit call.

<?php
   }
   }
   exit;
   mysql_close()
 ?>

You need to rethink your logic in the download file. You also call 

header("Content-length: $size");
exit;
print $content;

Upvotes: 0

Related Questions