CODEWITHSUNDEEP
c#windows-phoneasync-await
Jaydeep Solanki
Jaydeep Solanki

Reputation: 2945

simply stop an async method

I have this method which plays a sound, when the user taps on the screen, & I want it to stop playing it when the user taps the screen again. But the problem is "DoSomething()" method doesn't stop, it keeps going till it finishes.

bool keepdoing = true;

private async void ScreenTap(object sender, System.Windows.Input.GestureEventArgs e)
    {
        keepdoing = !keepdoing;
        if (!playing) { DoSomething(); }
    }

private async void DoSomething() 
    {
        playing = true;
        for (int i = 0; keepdoing ; count++)
        {
            await doingsomething(text);
        }
        playing = false;
    }

Any help will be appreciated.
Thanks :)

Upvotes: 18

Views: 37279

Answers (2)

abhigdeal
abhigdeal

Reputation: 161

Another way to use CancellationToken without throwing exceptions would be to declare/initialize CancellationTokenSource cts and pass cts.Token to DoSomething as in Stephen Cleary's answer above. 

private async void DoSomething(CancellationToken token) 
{
    playing = true;
    for (int i = 0; keepdoing ; count++)
    {
        if(token.IsCancellationRequested)
        {
         // Do whatever needs to be done when user cancels or set return value
         return;
        }
        await doingsomething(text);
    }
    playing = false;
}

Upvotes: 5

Stephen Cleary
Stephen Cleary

Reputation: 456437

This is what a CancellationToken is for.

CancellationTokenSource cts;

private async void ScreenTap(object sender, System.Windows.Input.GestureEventArgs e)
{
  if (cts == null)
  {
    cts = new CancellationTokenSource();
    try
    {
      await DoSomethingAsync(cts.Token);
    }
    catch (OperationCanceledException)
    {
    }
    finally
    {
      cts = null;
    }
  }
  else
  {
    cts.Cancel();
    cts = null;
  }
}

private async Task DoSomethingAsync(CancellationToken token) 
{
  playing = true;
  for (int i = 0; ; count++)
  {
    token.ThrowIfCancellationRequested();
    await doingsomethingAsync(text, token);
  }
  playing = false;
}

Upvotes: 34

Related Questions