CODEWITHSUNDEEP
javascript
Bryan
Bryan

Reputation: 3009

Javascript slideshow won't stop

I'm creating a web page with a slide show activated by clicking a button. When I click the button the first time, I want the user to be prompted with how fast they want it to change to the next image before actually running the slide show. The next time the button is clicked, I want the slideshow to stop. Right now the first part is working, but when I click it a second time it just shows the prompt again and doesn't stop the slideshow. Can anyone tell me what I'm doing wrong? Here is my code for the given function:

function slideShow(){
var temp2 = 0;
  if (temp2 == 0){
    var speed = prompt("How fast would you like to the slideshow to go?");
    var timerID = setInterval("clock()",speed);
    temp2 = 1;
  }
  else if (temp2 == 1){
  clearInterval(timerID);
  temp2 = 0;
  }
}

Upvotes: 0

Views: 82

Answers (1)

Joe
Joe

Reputation: 82654

Move 

var timerID

to outside of the function declaration. 

var timerID
function slideShow(){
var temp2 = 0;
  if (temp2 == 0){
    var speed = prompt("How fast would you like to the slideshow to go?");
    timerID = setInterval("clock()",speed);
    temp2 = 1;
  }
  else if (temp2 == 1){
  clearInterval(timerID);
  temp2 = 0;
  }
}

That would be the easiest way. You are basically just throwing that variable away everytime you call that function.

Just so other advice. You don't really ever want to use a string in setInterval.

Upvotes: 1

Related Questions