Richard
Richard

Reputation: 49

My Bash script works improperly

I am making a bash script that displays a grade based on what the user enters. However, it is returning the wrong grade and I can't figure out why. I posted the code below. I am new to bash scripting as well.

#!/bin/bash

echo "Enter assignment mark (0 to 40): "
read assignment
echo "Enter Test1 mark (0 to 15): "
read test1
echo "Enter Test2 mark (1 to 15): "
read test2
echo "Enter Final Exam mark (1 to 30): "
read final

(( sum = ( $assignment / 40 * 40 ) + (  $test1 / 15 *15 ) + ( $test2 / 15 * 15 ) + ( $final / 30 * 30 ) ))

if [ $sum -ge "90" ] && [ $sum -le "100" ]
then
echo "Your final grade is an A+."
elif [ $sum -ge "85" ] && [ $sum -le "89" ]
then
echo "Your final grade is a A."
elif [ $sum -ge "80" ] && [ $sum -le "84" ]
then
echo "Your final grade is a A-."
elif [ $sum -ge "77" ] && [ $sum -le "79" ]
then
echo "Your final grade is a B+."
elif [ $sum -ge "73" ] && [ $sum -le "76" ]
then
echo "Your final grade is a B."
elif [ $sum -ge "70" ] && [ $sum -le "72" ]
then
echo "Your final grade is a B-."
elif [ $sum -ge "67" ] && [ $sum -le "69" ]
then
echo "Your final grade is a C+."
elif [ $sum -ge "63" ] && [ $sum -le "66" ]
then
echo "Your final grade is a C."
elif [ $sum -ge "60" ] && [ $sum -le "62" ]
then
echo "Your final grade is a C-."
elif [ $sum -ge "57" ] && [ $sum -le "59" ]
then
echo "Your final grade is a D+."
elif [ $sum -ge "53" ] && [ $sum -le "56" ]
then
echo "Your final grade is an D."
elif [ $sum -ge "50" ] && [ $sum -le "52" ]
then
echo "Your final grade is an D-."
elif [ $sum -le "49" ] 
then
echo "Your final grade is an F. Sorry!"
fi

Upvotes: 0

Views: 221

Answers (1)

ophintor
ophintor

Reputation: 180

I don't understand this line:

(( sum = ( $assignment / 40 * 40 ) + (  $test1 / 15 *15 ) + ( $test2 / 15 * 15 ) + ( $final / 30 * 30 ) ))

Dividing and multiplying by the same number seems to be useless. Why not changing it to

(( sum =  $assignment + $test1 + $test2 + $final ))

EDIT: This code works. Enjoy ;-)

#!/bin/bash

echo "Enter assignment mark (0 to 40): "
read assignment
echo "Enter Test1 mark (0 to 15): "
read test1
echo "Enter Test2 mark (1 to 15): "
read test2
echo "Enter Final Exam mark (1 to 30): "
read final

sum=$(( assignment  +  test1  +  test2 + final  ))

if [[ $sum -ge 90 ]] && [[ $sum -le 100 ]]
then
echo Your final grade is an A+.
elif [[ $sum -ge 85 ]] && [[ $sum -le 89 ]]
then
echo Your final grade is a A.
elif [[ $sum -ge 80 ]] && [[ $sum -le 84 ]]
then
echo Your final grade is a A-.
elif [[ $sum -ge 77 ]] && [[ $sum -le 79 ]]
then
echo Your final grade is a B+.
elif [[ $sum -ge 73 ]] && [[ $sum -le 76 ]]
then
echo Your final grade is a B.
elif [[ $sum -ge 70 ]] && [[ $sum -le 72 ]]
then
echo Your final grade is a B-.
elif [[ $sum -ge 67 ]] && [[ $sum -le 69 ]]
then
echo Your final grade is a C+.
elif [[ $sum -ge 63 ]] && [[ $sum -le 66 ]]
then
echo Your final grade is a C.
elif [[ $sum -ge 60 ]] && [[ $sum -le 62 ]]
then
echo Your final grade is a C-.
elif [[ $sum -ge 57 ]] && [[ $sum -le 59 ]]
then
echo Your final grade is a D+.
elif [[ $sum -ge 53 ]] && [[ $sum -le 56 ]]
then
echo Your final grade is an D.
elif [[ $sum -ge 50 ]] && [[ $sum -le 52 ]]
then
echo Your final grade is an D-.
elif [[ $sum -le 49 ]] 
then
echo Your final grade is an F. Sorry!
fi

Upvotes: 1

Related Questions