CODEWITHSUNDEEP
javascriptjqueryonclick
916 Networks
916 Networks

Reputation: 545

Add variable to end of href URL onClick JQUERY

I feel like this should work, but doesn't. Not sure what I'm doing wrong.

function addURL()
{   
$(this).attr('href', function() {
return this.href + '&cylnders=12';
}   


<a onclick="addURL();" href="/search-results/?var1=red&var2=leather">Click this</a>

Upvotes: 17

Views: 85641

Answers (3)

Nirmal
Nirmal

Reputation: 2368

     function addURL()
      {
     var data=window.location+"&cylnders=12";
     alert(data);
     }

Try this concept. hope it will give you some solution.

Try this too

          function addURL()
          {
               window.location.href='/search-results/?var1=red&var2=leather&cylnders=12'
           }

Upvotes: 2

luchosrock
luchosrock

Reputation: 708

Why don't you add an ID or Class to your link href to identify it through jquery? It seems like your link is triggered before you can add any data to href attribute.

<a class="datalink" href="/search-results/?var1=red&var2=leather">Click this</a>
<script>

$('.datalink').attr('href', function() {
return this.href + '&cylnders=12';

});

</script>

Upvotes: 4

Christophe
Christophe

Reputation: 28154

First, you are missing a bunch of brackets:

function addURL()
{
    $(this).attr('href', function() {
        return this.href + '&cylnders=12';
    });
}

Second, in your code "this" refers to the window, not the element. Try this instead:

<a onclick="addURL(this)" href="/search-results/?var1=red&var2=leather">Click this</a>

function addURL(element)
{
    $(element).attr('href', function() {
        return this.href + '&cylnders=12';
    });
}

Upvotes: 32

Related Questions