CODEWITHSUNDEEP
inno-setup
max
max

Reputation: 1060

Uninstall fails because program is running. How do I make Inno Setup check for running process prior to attempting delete?

Inno Setup fails to remove components during uninstall cause my program is still running and the executable cannot be deleted. How do I have it check to see if it is running before allowing uninstall to proceed?

Upvotes: 29

Views: 29390

Answers (5)

Walter Verhoeven
Walter Verhoeven

Reputation: 4421

perhaps add this property

CloseApplications=yes it will look at all the [Files] and [InstallDelete] elements and work using windows restart manager

https://jrsoftware.org/ishelp/index.php?topic=setup_closeapplications

Upvotes: 0

Martin Prikryl
Martin Prikryl

Reputation: 202242

Use the AppMutex directive to prevent the uninstaller from proceeding, when an application is running.

[Setup]
AppMutex=MyProgMutex

The application has to create the mutex specified by the directive. See the linked AppMutex directive documentation for examples.

If you want to have the uninstaller kill the application, when it is still running, use this code instead:

function InitializeUninstall(): Boolean;
var
  ErrorCode: Integer;
begin
  if CheckForMutexes('MyProgMutex') and
     (MsgBox('Application is running, do you want to close it?',
             mbConfirmation, MB_OKCANCEL) = IDOK) then
  begin
    Exec('taskkill.exe', '/f /im MyProg.exe', '', SW_HIDE, 
         ewWaitUntilTerminated, ErrorCode);
  end;

  Result := True;
end;

As with the AppMutex directive above, the application has to create the mutex specified in the CheckForMutexes call.

Note that for installer, you do not have to code this. The installer has restart manager built-in.
See Kill process before (re)install using "taskkill /f /im" in Inno Setup.

Upvotes: 11

sky-dev
sky-dev

Reputation: 6258

Try this solution! I had issues with other solutions closing the app, but Inno Setup still thought the installed files were locked.

Remember to define your constants:

#define MyAppName "AppName"
#define MyAppExeName "AppName.exe"

[Code]
function InitializeUninstall(): Boolean;
  var ErrorCode: Integer;
begin
  ShellExec('open','taskkill.exe','/f /im {#MyAppExeName}','',SW_HIDE,ewNoWait,ErrorCode);
  ShellExec('open','tskill.exe',' {#MyAppName}','',SW_HIDE,ewNoWait,ErrorCode);
  result := True;
end;

Major props to the original source of this solution.

Upvotes: 15

kdoteu
kdoteu

Reputation: 1557

We used an other way than described above. Because this is an uninstallation we can kill the application and unistall it. The simpliest way, when u can't use AppMutex: (related to Really killing a process in Windows)

[UninstallRun]
Filename: "{cmd}"; Parameters: "/C ""taskkill /im <precessname>.exe /f /t"

Hope somebody will help this. I searched a long time for this.

Upvotes: 28

jitter
jitter

Reputation: 54605

Check these

Inno Setup: Detect instances running in any user session with AppMutex

Inno Setup: Is application running?

Inno Setup: Detect if an application is running

There are several ways. If your program defines a mutex use

[Setup]
AppMutex=MyMutexName

or for a specified mutex in the Code section

function CheckForMutexes (Mutexes: String): Boolean;

You could also use

function FindWindowByClassName (const ClassName: String): Longint;

to get the window handle by class name and send it messages.

Or get it by the name

function FindWindowByWindowName (const WindowName: String): Longint;

Or you use one of several DLL files for this specific use case

Or do it yourself after reading

How To Terminate an Application "Cleanly" in Win32

How To Enumerate Applications Using Win32 APIs (this one links to the german version as for some reason I can't find the english version of KB175030

or try the google translated version of the KB175030-DE

KB175030 DE -> EN

Upvotes: 28

Related Questions