CODEWITHSUNDEEP
c++qtforeach
shoosh
shoosh

Reputation: 78954

Why is foreach iterating with a const reference?

I try to do the following:

QList<QString> a;
foreach(QString& s, a)
{
    s += "s";
}

Which looks like it should be legitimate but I end up with an error complaining that it cannot convert from 'const QString' to 'QString &'.

Why is the Qt foreach iterating with a const reference?

Upvotes: 13

Views: 16094

Answers (5)

ymoreau
ymoreau

Reputation: 3996

With C++11, Qt now encourages this standard for syntax instead of Qt foreach :

QList<QString> a;
for(auto& s : a)
{
    s += "s";
}

Upvotes: 3

TimW
TimW

Reputation: 8447

or you can use 

QList<QString> a;
BOOST_FOREACH(QString& s, a)
{
   s += "s";
}

Upvotes: 4

user122933
user122933

Reputation:

Maybe for your case:

namespace bl = boost::lambda;
std::for_each(a.begin(),a.end(),bl::_1 += "s");

Upvotes: 2

jamuraa
jamuraa

Reputation: 3429

As explained on the Qt Generic Containers Documentation:

Qt automatically takes a copy of the container when it enters a foreach loop. If you modify the container as you are iterating, that won't affect the loop. (If you don't modify the container, the copy still takes place, but thanks to implicit sharing copying a container is very fast.) Similarly, declaring the variable to be a non-const reference, in order to modify the current item in the list will not work either.

It makes a copy because you might want to remove an item from the list or add items while you are looping for example. The downside is that your use case will not work. You will have to iterate over the list instead: 

for (QList<QString>::iterator i = a.begin(); i != a.end(); ++i) { 
  (*i) += "s";
}

A little more typing, but not too much more.

Upvotes: 21

atomice
atomice

Reputation: 3112

I believe Qt's foreach takes a temporary copy of the original collection before iterating over it, therefore it wouldn't make any sense to have a non-const reference as modifying the temporary copy it would have no effect.

Upvotes: 2

Related Questions