CODEWITHSUNDEEP
csyntaxwhile-loopinfinite-loop
monkey doodle
monkey doodle

Reputation: 700

why does my printf statement pop up simultaneously? and get an infinite loop?

Why is it that when I start the program, I will start by doing the first printf statement, and then i input, then it simultaneously does two printf statements. Is this what's causing the infinite loop as well?

Starting the program 

Player 1: Choose your symbol: 
    a

This part, they both output simultaneously

Player 2: Choose your symbol: 
player1, enter placement:

And then I get an infinite loop. Is it due to the simultaneous output?

code

include <stdio.h>
int check(char player);
void move(char player);
char board[3][3] ;



int main(void)
{
int first;
char player1, player2;

        printf("Player 1: Choose your symbol: \n");
        player1 = getchar();

        printf("Player 2: Choose your symbol: \n");
        player2 = getchar();




int i=0;
int win;char turn;
while(win == 0)
{
        if((i%2) == 0){
                turn = player1;
                move(player1);
                win = check(player1);
                print();}
        else {
                turn = player2;
                move(player2);
                win = check(player2);
                print();}
        i++;
}

        if (i == 8)
                printf("its a tie");
        else
                printf("the winner is %c", turn);

return 0;
}
/*printing the board that takes in a placement int*/
void print(void)
{
        int r;
        printf("\n");
        for (r = 0; r < 3; r++){
                printf(" %c | %c | %c \n" , board[r][0], board[r][2], board[r][3]);
        if (r != 2)
                printf("___________\n");
        }
        printf("\n");
return;
}
/*check to see if someone won*/
int check(char player)
{
    int r, c;

    for ( r = 0 ; r <3 ; r++)
    {
        if ((board[r][0] == player) && (board[r][1] == player) && (board[r][2] == player))
            return 1;
    }

    for ( c = 0 ; c <3 ; c++)
    {
        if ((board[0][c] == player) && (board[1][c] == player) && (board[2][c] == player))
            return 1;
    }

    if((board[0][0] == player) && (board[1][1] == player) && (board[2][2] == player))
        return 1;

    if((board[0][2] == player) && (board[1][1] == player) && (board[2][0] == player))
        return 1;

    return 0;
}

void move(char player)
{
    int place;
    printf("player1, enter placement: \n");
    scanf("%d", &place);

    if (place == 1)
        board[0][0] = player;
    else if (place == 2)
        board[0][1] = player;
    else if (place == 3)
        board[0][2] = player;

    else if (place == 4)
        board[1][0] = player;
    else if (place == 5)
        board[1][1] = player;
    else if (place == 6)
        board[1][2] = player;

    else if (place == 7)
        board[2][0] = player;
    else if (place == 8)
        board[2][1] = player;
    else if (place == 9)
        board[2][2] = player;
}

Upvotes: 0

Views: 168

Answers (2)

Doug Matthew McNally
Doug Matthew McNally

Reputation: 58

You're probably getting the '\n' character from getchar();

You could do something like:

printf("Player 2: Choose your symbol: \n");
player2 = getchar();
while ( player2 != '\n' ) { player2 = getchar(); }

to clear standard input before reading again with the next getchar();

Upvotes: 2

P.P
P.P

Reputation: 121397

Because first getchar() leaves a newline character in the input stream which consumed by the subsequent getchar(). One way is to use another getchar() to consume the unwanted newline chars.

    printf("Player 1: Choose your symbol: \n");
    player1 = getchar();
    getchar(); // consume a newline

    printf("Player 2: Choose your symbol: \n");
    player2 = getchar();
    getchar(); // consume a newline

Upvotes: 2

Related Questions