Reputation: 101
I have a script say abc.sh which has list of commands with flags. example
//abc.sh
echo $FLAG_name
cp $FLAG_file1 $FLAG_file2
echo 'file copied'
I want to execute this script through python code. say
//xyz.py
name = 'FUnCOder'
filename1 = 'aaa.txt'
filename2 = 'bbb.txt'
subprocess.call([abc.sh, name, filename1, filname2], stdout=PIPE, stderr=PIPE, shell=True)
This call is not working.
What are the other options?
Also the shell script file is in some other directory. And I want the output to go in logs.
Upvotes: 6
Views: 34286
Reputation: 1126
Usually you want to use Popen
since you have process control afterwards. Try:
import subprocess
process = subprocess.Popen(['abc.sh', name, filename1, filname2], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
process.wait() # Wait for process to complete.
# iterate on the stdout line by line
for line in process.stdout.readlines():
print(line)
Upvotes: 5
Reputation: 1
I am on macOS and to run a shell script I used:
process = subprocess.Popen([abc.sh, name, filename1, filname2], shell=True)
Upvotes: 0
Reputation: 2988
I know this is a old question, below is the way if you are using Python 3.5 & above versions.
import subprocess
process = subprocess.run('script.sh', shell=True, check=True, timeout=10)
Ref: https://docs.python.org/3.5/library/subprocess.html#subprocess.run
Upvotes: 1
Reputation: 25833
Try this:
//xyz.py
name = 'FUnCOder'
filename1 = 'aaa.txt'
filename2 = 'bbb.txt'
process = subprocess.Popen(['abc.sh', name, filename1, filname2], stdout=PIPE)
process.wait()
Notice that 'abc.sh' is in quotes because it's not a variable name, but the command you're calling.
I would also, in general, recommend using shell=False
, though in some cases it is necessary to use shell=True
.
To put output into a file try:
with open("logfile.log") as file:
file.writelines(process.stdout)
Upvotes: 1