CODEWITHSUNDEEP
c++static
Aqeel Raza
Aqeel Raza

Reputation: 1829

Undefined reference to static variable c++

Hi i am getting undefined reference error in the following code:

class Helloworld{
  public:
     static int x;
     void foo();
};
void Helloworld::foo(){
     Helloworld::x = 10;
};

I don't want a static foo() function. How can I access static variable of a class in non-static method of a class?

Upvotes: 124

Views: 149866

Answers (3)

pvc
pvc

Reputation: 1180

Old question, but;

Since c++17 you can declare static members inline and instantiate them inside the body of class without the need of an out-of-class definition:

class Helloworld{
  public:
     inline static int x = 10;
     void foo();
};

Upvotes: 61

Andy Prowl
Andy Prowl

Reputation: 126412

I don't want a static foo() function

Well, foo() is not static in your class, and you do not need to make it static in order to access static variables of your class.

What you need to do is simply to provide a definition for your static member variable:

class Helloworld {
  public:
     static int x;
     void foo();
};

int Helloworld::x = 0; // Or whatever is the most appropriate value
                       // for initializing x. Notice, that the
                       // initializer is not required: if absent,
                       // x will be zero-initialized.

void Helloworld::foo() {
     Helloworld::x = 10;
};

Upvotes: 152

Pete Becker
Pete Becker

Reputation: 76235

The code is correct, but incomplete. The class Helloworld has a declaration of its static data member x, but there is no definition of that data member. Somehwere in your source code you need

int Helloworld::x;

or, if 0 isn't an appropriate initial value, add an initializer.

Upvotes: 80

Related Questions