CODEWITHSUNDEEP
androidandroid-activitybroadcastreceiver
zmbq
zmbq

Reputation: 39023

Activity opened twice

I have an application that uses Urban Airship for push notification. When a notification arrives and the user clicks on it, activity A in my application should open and do something.

I've installed the BroadcastReceiver as is shown in the docs, and it's almost working.

  1. When my app is in the foreground I don't let the user see the notification at all, and just handle it automatically.
  2. When my app is not running at all, the activity opens up just fine.
  3. When my app is in the background (which always happens when A is the top activity), a second instance of Activity A is created.

This is, of course, a problem. I don't want two A activities, I just want one of them. Here's the relevant BroadcastReceiver code:

@Override
public void onReceive(Context ctx, Intent intent)
{
    Log.i(tag, "Push notification received: " + intent.toString());
    String action = intent.getAction();
    int notificationId = intent.getIntExtra(PushManager.EXTRA_NOTIFICATION_ID, -1);
    if(action.equals(PushManager.ACTION_NOTIFICATION_OPENED))
    {
        Intent intentActivity = new Intent(ctx, ActivityA.class);
        intentActivity.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
        UAirship.shared().getApplicationContext().startActivity((intentActivity);
    }
}

UPDATE: I tried to bypass this bug by calling System.exit(0) when the user presses Back on Activity A. The process ended, but then it was restarted immediately! My BroadcastReceiver is not called again in the second instance. What's happening?

UPDATE 2: @codeMagic asked for more information about the app and activity A.

This app lets its user review certain items and comment on them. Activity A is started when the app is launched. If the user's session isn't valid any more, a Login activity is started. Once the user logs in, activity A becomes active again. A only has a "No items to review" message and a "Try now" button.

When the user logs in, the server starts sending push notifications whenever a new item is available for review. When the app gets the notification, activity A accesses the server and gets the next item to review. The item is shown in activity B. Once the review is submitted to the server, activity B finishes and activity A is again the top activity.

The server knows when a user is reviewing an item (because activity A fetched it), and doesn't send push notifications until the review is submitted - meaning a notification can't come if the user isn't logged in or if the user is viewing activity B.

While I agree there is a subtle race condition here, it is not causing the problem I'm seeing - in testing I am 100% positive there's no race condition - the push notification is only sent after Activity A becomes active again.

Upvotes: 9

Views: 14970

Answers (5)

Dan Alboteanu
Dan Alboteanu

Reputation: 10252

add those attributes in the Manifest - activity:

android:launchMode="singleTask"
android:taskAffinity=""
android:excludeFromRecents="true"

See https://developer.android.com/develop/ui/views/notifications/navigation

Upvotes: 0

Ram Iyer
Ram Iyer

Reputation: 1679

There are multiple scenarios when this could happen. One of them can be handled this way. Please see my answer here: https://stackoverflow.com/a/44117025/2959575

Upvotes: 0

Mr.Me
Mr.Me

Reputation: 9286

Ok, two notes on this :

  • You can register a broadcast receiver via the manifest so it is independent of any parts of your app. and use a Singleton pattern (keep a static reference to your activity somewhere in your app) that way you can check if their is an activity viewing or not and process accordingly.

    // your activity A

@Override
public void onCreate(Bundle bundle) {
    super.onCreate(bundle);
    myActivityReference = this;
}

public void onPause() {
    super.onPause();
    if (isFinishing()) {
        myActivityReference = null;
    }
}

  • or you can keep everything as it is and use activity lunching modes flags in your manifest such as singleTop, singleInstance ... etc. take a look here android activity lunch modes

Upvotes: -2

zmbq
zmbq

Reputation: 39023

The solution was to add a launchMode='singleTask' to the activity in AndroidManifest.xml . As a result, instead of a new activity, onNewIntent of the same activity instance is called.

Upvotes: 24

codeMagic
codeMagic

Reputation: 44571

You can use one of several Intent Flags. FLAG_ACTIVITY_REORDER_TO_FRONT being one of them. This will bring the Activity to the front of the stack if it is already in the stack and if not then it will create a new instance. I believe you will still need FLAG_ACTIVITY_NEW_TASK if you aren't calling it from an Activity

Intent.FLAG_ACTIVITY_CLEAR_TOP should also work. But this will clear any other Activities on the stack. It just depends on what other functionality you need. Look through the Intent Flags and see which of these will work best for you

Upvotes: 3

Related Questions