NullPointerException when retrieving files from save location

Question

I'm building an Android app that takes a picture and then immediately goes to a crop screen. I couldn't figure out how to pass the image without downgrading it (i.e. if i was to put it in a Bundle), so I just decided to save the image and pull it back off the card.

Right now when I'm trying to get the image back in the new crop_view, which comes right after the camera_view, the app throws a Null Pointer Exception on the line indicated in the code below. The image is actually being set at Pictures/MyApp/IMG_APP.jpg where "Pictures" is my default picture directory.

public Bitmap getImage() {
    Bitmap toReturn = null;

    File root = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES);
    ImageView IV = (ImageView) findViewById(R.id.crop_view);
    toReturn = BitmapFactory.decodeFile(root+"/MyApp/IMG_APP.jpg");
    IV.setImageBitmap(toReturn);
    return toReturn;// TODO Fix this line. It is breaking here with a null pointer exception.
}

Below this is the code where the picture is being saved. I have confirmed that it is being saved by checking on the actual sd card in another app.

    void onPictureJpeg(byte[] bitmapdata, Camera camera) {
        int i = bitmapdata.length;
        Log.d(TAG, String.format("bytes = %d", i));

        File f = IMGP_Photo_Handler.generateTimeStampPhotoFile();

        try {
            OutputStream outputStream = new BufferedOutputStream(new FileOutputStream(f));
            outputStream.write(bitmapdata);
            outputStream.flush();
            outputStream.close();
            exceptionCaught = false;

        } catch (Exception e) {
            Log.e(TAG, "Error accessing photo output file:" + e.getMessage());
            Toast
              .makeText(IMGP_Camera.this, "Cannot save file. \nPlease mount an external SD Card", Toast.LENGTH_LONG)
              .show();
            exceptionCaught = true;// To get this to not start the next intent if the file save doesn't work.
        }

        if(!exceptionCaught){
        sendBroadcast(new Intent(Intent.ACTION_MEDIA_MOUNTED,
                Uri.parse("file://" + Environment.getExternalStorageDirectory())));

        Intent intent = new Intent();
        intent.setClass(IMGP_Camera.this, IMGP_Crop.class);
        intent.putExtra("po","3265695");
        startActivity(intent);
        }
        finish();

    }

And then finally my photo_handler:

    public static Uri photoFileUri = null;

    public static File getPhotoDirectory()  {
        File outputDir = null;
        String externalStorageState = Environment.getExternalStorageState();
        if (externalStorageState.equals(Environment.MEDIA_MOUNTED)) {
            File pictureDir =
                Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES);
            outputDir = new File(pictureDir, "MyApp");
            if(!outputDir.exists())  {
                if(!outputDir.mkdirs()) {
                    String message = "Failed to create directory:" + outputDir.getAbsolutePath();
                    Log.e(TAG, message);
                    outputDir = null;
                }
            }
        }

        return outputDir;
    }

    public static File generateTimeStampPhotoFile() {
        File photoFile = null;
        File outputDir = getPhotoDirectory();

        if (outputDir != null) {
            String photoFileName =  "IMG_APP.jpg";
            photoFile = new File(outputDir, photoFileName);
        }

        return photoFile;
    }

    public static Uri generateTimeStampPhotoFileUri() {
        photoFileUri = null;
        File photoFile = generateTimeStampPhotoFile() ;

        if (photoFile != null) {
            photoFileUri = Uri.fromFile(photoFile);
        }

        return photoFileUri;
    }

    public static Uri getFile(){
        return photoFileUri;
    }

Answer 1

I fixed this by passing the path to the photo and uri in an extra:

String photoFileName =  "IMG_TQL.jpg";
photoFile = new File(outputDir, photoFileName);
photoFilePath = photoFile.getAbsolutePath();


Intent intent = new Intent();
intent.setClass(IMGP_Camera.this, IMGP_Crop.class);
intent.putExtra("path", path);
intent.putExtra("uri", uri);
startActivity(intent);