CODEWITHSUNDEEP
javaswinglayoutjframejpanel
Muniu
Muniu

Reputation: 13

JPanel appearing to be two times bigger than set resolution

I must say I tried everything and I can't understand what's wrong with my code. In my SIView class I create MainFrame which extends JFrame with specified resolution (let's say X,Y). Then I create gamePanel which extends JPanel whith the same resolution as MainFrame, and add it to MainFrame. The problem is that effective resolution of the panel is twice as big (x*2, y*2). It's like the panel is being streched to be twice as big.

Frame will display only a quarter (upper left quarter) of the panel either with pack() or mannualy setting the size, unless I set it to double the resolution in which case It's ok, but that's not a proper way to do that(When calculating positions in the game I have to double everything or divide it by 2 to keep proper proportions). I even tried different Layout managers wthout any succes.

Here's the code of the main view class:

public class SIView implements Runnable {

private final MainFrame mainFrame;
private final GamePanel gamePanel;

public SIView(BlockingQueue<SIEvent> eventQueue) {
    this.eventsQueue = eventQueue;
    mainFrame = new MainFrame();
    gamePanel = new GamePanel();

    gamePanel.setVisible(true);
    mainFrame.getContentPane().add(gamePanel);
    // mainFrame.pack();



@Override
public void run() {
    mainFrame.setVisible(true);
}

public void init() {
    SwingUtilities.invokeLater(this);

}
  //some code not related

}

the frame class: 

public class MainFrame extends JFrame {
/**
 * 
 */
private static final long serialVersionUID = 6513420589842315661L;

public MainFrame() {
    setTitle("Space Intruders");
    setSize(new Dimension(SIParams.RES_X, SIParams.RES_Y));
    setResizable(false);
    setLayout(null);

    setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
}
}

panel class:

public class GamePanel extends JPanel {

/**
 * 
 */
private static final long serialVersionUID = 8112087715257989968L;

private final PlayerShipView playerShip;
private final ArrayList<SmallEnemyShipView> smallEnemyShip;
private final ArrayList<LightMissleView> lightMissle;

public GamePanel() {
    setPreferredSize(new Dimension(SIParams.RES_X, SIParams.RES_Y));
    setMaximumSize(new Dimension(SIParams.RES_X, SIParams.RES_Y));
    setBounds(0, 0, SIParams.RES_X, SIParams.RES_Y);
    setBackground(new Color(0, 0, 0));
    setLayout(new OverlayLayout(this));

    setDoubleBuffered(true);
    // TODO
    playerShip = new PlayerShipView();
    smallEnemyShip = new ArrayList<SmallEnemyShipView>();
    lightMissle = new ArrayList<LightMissleView>();
    this.add(playerShip);

}

@Override
public void paintComponent(Graphics g) {
    super.paintComponent(g);
}

//some code not related
}

Upvotes: 1

Views: 615

Answers (2)

Muniu
Muniu

Reputation: 13

I just solved everything :D But I must say I feel stupid. The problem was with painting my components, in paintcomponent() method I painted rectangle on a relative position while changing component position also relatively. That gave the effect of 2xtimes movement etc. because while the component was moving the rectangle was moving inside of it too. I guess I have a lot to learn about Swing ;) Sorry for all this trouble ;)

PS. I didn't have to change anything in Panel/Frame classes except for using pack() method after everything.

Upvotes: 0

Guillaume Polet
Guillaume Polet

Reputation: 47627

If I use LayoutManager and properly override getPreferredSize() in GamePanel, the code seems to work as expected:

import java.awt.Color;
import java.awt.Dimension;
import java.awt.Graphics;

import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.SwingUtilities;

import org.jfree.ui.OverlayLayout;

public class SIView implements Runnable {

    public static interface SIParams {

        int RES_X = 500;
        int RES_Y = 400;
    }

    public static class GamePanel extends JPanel {
        public GamePanel() {
            setBackground(new Color(0, 0, 0));
            setLayout(new OverlayLayout());
        }

        @Override
        public Dimension getPreferredSize() {
            return new Dimension(SIParams.RES_X, SIParams.RES_Y);
        }

        @Override
        public void paintComponent(Graphics g) {
            super.paintComponent(g);
        }

        // some code not related
    }

    private JFrame mainFrame;
    private GamePanel gamePanel;

    @Override
    public void run() {
        mainFrame = createMainFrame();
        gamePanel = new GamePanel();
        mainFrame.getContentPane().add(gamePanel);
        mainFrame.pack();
        mainFrame.setVisible(true);
    }

    private JFrame createMainFrame() {
        JFrame frame = new JFrame();
        frame.setTitle("Space Intruders");
        frame.setResizable(false);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        return frame;
    }

    public void init() {
        SwingUtilities.invokeLater(this);

    }

    // some code not related

    public static void main(String[] args) {
        new SIView().init();
    }

}

I also dropped the MainFrame class since it is not needed to extend JFrame in this context.

Upvotes: 2

Related Questions