CODEWITHSUNDEEP
authenticationmeteoraccountsmeteorite
jptsetung
jptsetung

Reputation: 9156

Trying to add another service to the meteor accounts package

I've found this on github that shows how to add github login to the accounts. https://github.com/Jabbslad/accounts-github

Instead of installing the package with "mrt add accounts-github", I'm downloading the sources, and trying to make them work with a simple app. The goal of this is to make a few changes to the code to understand how it works and finally make my own extension to accounts.

But I get errors "Cannot read property 'github' of undefined at app/accounts-github/github_common.js:1:36".

Thx for your help.

Upvotes: 1

Views: 425

Answers (2)

jptsetung
jptsetung

Reputation: 9156

So the problem was the git for accounts-github was not updated with the latest evolutions from meteor. So I replaced "Meteor.accounts" with "Accounts" in all files and now it works.

Upvotes: 1

Tarang
Tarang

Reputation: 75945

Because you added the package yourself you need to ensure the dependencies are also installed. You can find the dependencies in package.js

If you want to make the package from scratch ensure you also use a package in your meteor app. This means that you put your stuff in a directory called accounts-github in a directory called packages in the root directory of your meteor app.

You can also add these dependencies in yourself if you don't want to use a package:

meteor add accounts-base
meteor add accounts-oauth2-helper
meteor add http

Some dependencies should be in with meteor (i.e templating)

Upvotes: 2

Related Questions