CODEWITHSUNDEEP
node.js
user342673
user342673

Reputation: 664

how to correctly store shared data via a variable in a module

My application has some shared data in database, instead of reading them for each request, I want to read them out only once and store them as an array in a module. However, I am not sure how to do this correctly, any helps will be greatly appreciated. Thanks!

var isStored = false;
var isStroing = false;
var allRecords = [];

function getSharedData(callback) {
   if (isStored) {
      callback(null, allRecords);
      return;
   }
   if (isStoring) {  // check to see if other request is doing the storing now
      // IT HAS TO WAIT AND GET THE RESULT LATER, BUT NOT SURE HOW TO DO IT
   }
   isStoring = true;

   ......
   // invoke a function retrieve the data from database;
   // populate allRecords array and set isStored to true
   .....
}

After some thinking, here is my solution. 

var isStored = false;
var isStroing = false;
var allRecords = [];
var getSharedDataCallbacks = [];

function getSharedData(callback) {
   if (isStored) {
      callback();
      return;
   }

   getSharedDataCallbacks.push(callback);
   if (isStoring) {  
      return;
   }
   isStoring = true;

   // queryDatabase is not defined, basically, it retrieves
   // the data from database
   queryDatabase(function (error, result) {  
      var callbacks = getSharedDataCallbacks;
      getSharedDataCallbacks = [];
      isStroing = false;

      if (error) {
        callbacks.forEach(function (oneCallback) {
           oneCallback(error);
        }
        return;
      }
      allRecords = result; // assume result is an array 
      callbacks.forEach(function (oneCallback) {
          oneCallback();
      }
   });
}

function setSharedData(callback) {
    getSharedData.call(this, function (error) {
       if (error) {
          callback(error);
          return;
       }
       callback(null, allRecords);
    });
}

Upvotes: 2

Views: 196

Answers (1)

user405398
user405398

Reputation:

Something like this could help:

var loaded = false;
var loading = false;
var allRecords = [];

function getSharedData(callback) {
   if (loaded) {
      return callback(null, allRecords);
   }
   if (loading) {
      return (loading[loading.legnth] = callback);
   }

   loading = [callback];

   return loadData(afterLoad); //loadData is your function to load data.


   function afterLoad(err, data) {
       //process and assign to allRecords
       var i = 0
       , loadingLen = loading.length
       ;
       for(i; i < loadingLen; i++) {
         (function(cb, data) {
           cb(null, data);
         })(loading[i], allRecords);
       }

       loading.length = 0;
       loaded = true;
   }
}

Upvotes: 1

Related Questions