CODEWITHSUNDEEP
ioscocoansdatenscalendar
Peter Lapisu
Peter Lapisu

Reputation: 20965

NSCalendar, why does setting the firstWeekday doesn't effect calculation outcome?

i need to calculate the weekday for a given date, however, depending on the calendar a week can star on Monday and somwhere on Sunday

so i wanted to set it, to start on Monday, using

[[NSCalendar currentCalendar] setFirstWeekday:2];

however, the calculation outcome is the same

{
    [[NSCalendar currentCalendar] setFirstWeekday:1];
    NSDateComponents *weekdayComponents = [[NSCalendar currentCalendar] components:(NSDayCalendarUnit | NSWeekdayCalendarUnit) fromDate:date];
    NSInteger weekday = [weekdayComponents weekday] - 1;
    NSLog(@"%d", weekday);
}
{
    [[NSCalendar currentCalendar] setFirstWeekday:2];
    NSDateComponents *weekdayComponents = [[NSCalendar currentCalendar] components:(NSDayCalendarUnit | NSWeekdayCalendarUnit) fromDate:date];
    NSInteger weekday = [weekdayComponents weekday] - 1;
    NSLog(@"%d", weekday);
}

returns same numbers, but why?

Upvotes: 7

Views: 8103

Answers (3)

ViktoR
ViktoR

Reputation: 761

A useful function to get corrected weekday number for different firstWeekday cases

Swift 3.0

func dayOfWeek(day: Int, month: Int, year: Int) -> Int {
    let calendar = Calendar.current
    let dateComponents = DateComponents(year: year, month: month, day: day)

    guard let date = calendar.date(from: dateComponents) else {
        fatalError("Can't create date form specified date components")
    }

    var weekday = calendar.component(.weekday, from: date)

    //handling the case when calendar starts from Monday: firstWeekday == 2
    if calendar.firstWeekday == 2 {
        weekday = (weekday == 1) ? 7 : (weekday - 1)
    }

    return weekday
}

Upvotes: 0

James Holderness
James Holderness

Reputation: 23001

I believe you need to use the ordinalityOfUnit:inUnit:forDate: method rather than attempting to extract the date components. So something like this:

NSUInteger weekday = [[NSCalendar currentCalendar] ordinalityOfUnit:NSWeekdayCalendarUnit inUnit:NSWeekCalendarUnit forDate:date];

Basically that call is asking for the day (NSWeekdayCalendarUnit) in the week (NSWeekCalendarUnit) for the given date.

If that doesn't work as is, you may need to create your own calendar, rather than trying to modifying the first week day on the currentCalendar.

For example:

NSCalendarIdentifier calendarIdentifier = [[NSCalendar currentCalendar] calendarIdentifier];
NSCalendar *calendar = [[[NSCalendar alloc] initWithCalendarIdentifier:calendarIdentifier] autorelease];
[calendar setFirstWeekday:2];

Then use that new calendar object rather than [NSCalendar currentCalendar] in the ordinalityOfUnit:inUnit:forDate: call.

Upvotes: 5

anon
anon

Reputation:

The behavior you see is correct. The weekday component is not affected by the firstWeekday property. If you have a date representing a sunday it will always be a sunday wether you start your week on that sunday or on monday. What this should affect is the week number in the week property of your date components.

Upvotes: 11

Related Questions